Add rolloutStategy parameter to ImageRegistrySpec#560
Add rolloutStategy parameter to ImageRegistrySpec#560openshift-merge-robot merged 1 commit intoopenshift:masterfrom Fedosin:image_registry_rollout
Conversation
openshift-ci-robot
added
the
size/XS
| // rolloutStrategy defines rollout strategy for the image registry | ||
| // deployment. | ||
| // +optional | ||
| RolloutStrategy string `json:"rolloutStrategy" protobuf:"bytes,15,opt,name=rolloutStrategy"` |
There was a problem hiding this comment.
@sttts can we make this a appsv1.DeploymentStrategyType [1]? Would we automatically get the validation pattern we want?
If not, then the validation pattern needs to be added as a comment tag - see [2] as an example.
[1] https://github.com/kubernetes/api/blob/master/apps/v1/types.go#L335
[2] https://github.com/openshift/api/blob/master/imageregistry/v1/types.go#L239
There was a problem hiding this comment.
@adambkaplan upstream types are coded (and validated) in Go. There is no connection to these validation here and those in Go land.
To allow us to define a rollout strategy for the image registry deployment, we create an additional parameter in ImageRegistrySpec.
Fedosin
left a comment
Fedosin
left a comment
There was a problem hiding this comment.
Thanks for the review!
| // rolloutStrategy defines rollout strategy for the image registry | ||
| // deployment. | ||
| // +optional | ||
| RolloutStrategy string `json:"rolloutStrategy" protobuf:"bytes,15,opt,name=rolloutStrategy"` |
openshift-ci-robot
added
size/S
|
/assign @sttts |
|
/approve hold for @adambkaplan to have a last look. Remove hold at will. |
openshift-ci-robot
added
lgtm
openshift-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, Fedosin, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5 participants
To allow us to define a rollout strategy for the image registry deployment, we create an additional parameter in ImageRegistrySpec.