baremetal: Remove nodeDNSIP from platform status#600
baremetal: Remove nodeDNSIP from platform status#600cybertron wants to merge 1 commit intoopenshift:masterfrom
Conversation
|
/hold Until the dependencies merge. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: cybertron The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/cc @mandre @jcpowermac @rgolangh I think we need something similar for openstack, vpshere and RHV. |
Use of this field is being removed in [0] and [1]. Once those two PRs have merged there will no longer be any use for it. 0: openshift/machine-config-operator#1569 1: openshift/installer#3304
| // BareMetal deployments. In order to minimize necessary changes to the | ||
| // datacenter DNS, a DNS service is hosted as a static pod to serve those hostnames | ||
| // to the nodes in the cluster. | ||
| NodeDNSIP string `json:"nodeDNSIP,omitempty"` |
There was a problem hiding this comment.
When and where this was deprecated, why that information was not exposed to consumers of the API before?
There was a problem hiding this comment.
Good point, we never actually deprecated this. It was just discovered that we no longer need it thanks to some other changes. For the moment I guess we should deprecate it and leave it in the api. It won't be used by anything, but at least it won't break any consumers.
What is the process for deprecating a field like this?
|
@smarterclayton I'm inclined to simply remove instantly and backport quickly to avoid deps. Otherwise, this field become unmaintained and potentially risky. We don't expose general read rights on these resources. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Use of this field is being removed in [0] and [1]. Once those two
PRs have merged there will no longer be any use for it.
0: openshift/machine-config-operator#1569
1: openshift/installer#3304