Skip to content

baremetal: Remove nodeDNSIP from platform status#600

Closed
cybertron wants to merge 1 commit intoopenshift:masterfrom
cybertron:no-dns-vip
Closed

baremetal: Remove nodeDNSIP from platform status#600
cybertron wants to merge 1 commit intoopenshift:masterfrom
cybertron:no-dns-vip

Conversation

@cybertron
Copy link
Copy Markdown
Member

Use of this field is being removed in [0] and [1]. Once those two
PRs have merged there will no longer be any use for it.

0: openshift/machine-config-operator#1569
1: openshift/installer#3304

@cybertron
Copy link
Copy Markdown
Member Author

/hold

Until the dependencies merge.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 17, 2020
@openshift-ci-robot
Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cybertron
To complete the pull request process, please assign soltysh
You can assign the PR to them by writing /assign @soltysh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhinavdahiya
Copy link
Copy Markdown
Contributor

/cc @mandre @jcpowermac @rgolangh I think we need something similar for openstack, vpshere and RHV.

Use of this field is being removed in [0] and [1]. Once those two
PRs have merged there will no longer be any use for it.

0: openshift/machine-config-operator#1569
1: openshift/installer#3304
// BareMetal deployments. In order to minimize necessary changes to the
// datacenter DNS, a DNS service is hosted as a static pod to serve those hostnames
// to the nodes in the cluster.
NodeDNSIP string `json:"nodeDNSIP,omitempty"`
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When and where this was deprecated, why that information was not exposed to consumers of the API before?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, we never actually deprecated this. It was just discovered that we no longer need it thanks to some other changes. For the moment I guess we should deprecate it and leave it in the api. It won't be used by anything, but at least it won't break any consumers.

What is the process for deprecating a field like this?

@deads2k
Copy link
Copy Markdown
Contributor

deads2k commented Mar 31, 2020

@smarterclayton I'm inclined to simply remove instantly and backport quickly to avoid deps. Otherwise, this field become unmaintained and potentially risky. We don't expose general read rights on these resources.

@openshift-bot
Copy link
Copy Markdown

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 4, 2020
@openshift-bot
Copy link
Copy Markdown

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 3, 2020
@openshift-bot
Copy link
Copy Markdown

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link
Copy Markdown

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants