Add ExternalCloudProvider TechPreviewNoUpgrade featureGate by Danil-Grigorev · Pull Request #738 · openshift/api

Danil-Grigorev · 2020-09-16T14:11:49Z

Implementing feature gate selection to run CCM in openshift. https://github.com/openshift/enhancements/pull/463/files#diff-3e0e2c48e70215076dfe36c13768a823ab7080d929d80292f37db2ef5a2121e8R199

Danil-Grigorev · 2020-09-17T12:44:40Z

/retest

michaelgugino

We don't need this change.

We should deduce in the KCM operator which options to use based on the platform we're using. We're not making this configurable for users.

Danil-Grigorev · 2020-09-21T13:40:49Z

We don't need this change.

We should deduce in the KCM operator which options to use based on the platform we're using. We're not making this configurable for users.

Would an annotation on this resource be a sufficient/ok temporal change not exposed in the API to trigger the transition? This would be a simple change

openshift-bot · 2020-12-20T16:47:00Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot · 2021-01-19T18:38:01Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

openshift-ci-robot · 2021-02-03T13:21:56Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Danil-Grigorev
To complete the pull request process, please assign smarterclayton after the PR has been reviewed.
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Danil-Grigorev · 2021-02-03T13:27:18Z

/remove-lifecycle rotten

Danil-Grigorev · 2021-02-03T13:41:37Z

/test verify

openshift-bot · 2021-05-04T19:20:01Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-ci · 2021-05-04T19:24:10Z

@Danil-Grigorev: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-06-03T22:56:39Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

elmiko

i was reading through this code again, and had a question

elmiko · 2021-06-29T20:32:38Z

 	},
-	TechPreviewNoUpgrade: newDefaultFeatures().toFeatures(),
+	TechPreviewNoUpgrade: newDefaultFeatures().with(
+		"ExternalCloudProvider",


should we have a comment here?

Suggested change

"ExternalCloudProvider",

"ExternalCloudProvider", // sig-cloud-provider, danil-grigorev, elmiko

openshift-bot · 2021-07-30T02:09:14Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2021-07-30T02:09:23Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Danil-Grigorev changed the title ~~Add PlatformStatus.External field~~ [WIP] Add PlatformStatus.External field Sep 16, 2020

openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 16, 2020

openshift-ci-robot requested review from deads2k and eparis September 16, 2020 14:12

Danil-Grigorev force-pushed the external-infra-support branch from 956aacd to 1c52a23 Compare September 17, 2020 12:43

Danil-Grigorev changed the title ~~[WIP] Add PlatformStatus.External field~~ Add PlatformStatus.External field Sep 17, 2020

openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Sep 17, 2020

michaelgugino suggested changes Sep 18, 2020

View reviewed changes

Danil-Grigorev mentioned this pull request Sep 22, 2020

Describing steps to support out-of-tree providers openshift/enhancements#463

Merged

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 20, 2020

openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jan 19, 2021

Danil-Grigorev force-pushed the external-infra-support branch from 1c52a23 to db641f6 Compare February 3, 2021 13:21

Danil-Grigorev changed the title ~~Add PlatformStatus.External field~~ Add ExternalCloudProvider TechPreviewNoUpgrade featureGate Feb 3, 2021

openshift-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Feb 3, 2021

Add ExternalCloudProvider TechPreview feature gate support

4c0df63

Danil-Grigorev force-pushed the external-infra-support branch from db641f6 to 4c0df63 Compare February 3, 2021 13:58

Danil-Grigorev mentioned this pull request Feb 9, 2021

[OCPCLOUD-1107] External cloud-provider support via FeatureGate in post-install openshift/machine-config-operator#2386

Merged

openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 4, 2021

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2021

openshift-ci Bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 3, 2021

elmiko reviewed Jun 29, 2021

View reviewed changes

openshift-ci Bot closed this Jul 30, 2021

	"ExternalCloudProvider",
	"ExternalCloudProvider", // sig-cloud-provider, danil-grigorev, elmiko

Conversation

Danil-Grigorev commented Sep 16, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Danil-Grigorev commented Sep 17, 2020

Uh oh!

michaelgugino left a comment

Choose a reason for hiding this comment

Uh oh!

Danil-Grigorev commented Sep 21, 2020

Uh oh!

openshift-bot commented Dec 20, 2020

Uh oh!

openshift-bot commented Jan 19, 2021

Uh oh!

openshift-ci-robot commented Feb 3, 2021

Uh oh!

Danil-Grigorev commented Feb 3, 2021

Uh oh!

Danil-Grigorev commented Feb 3, 2021

Uh oh!

openshift-bot commented May 4, 2021

Uh oh!

openshift-ci Bot commented May 4, 2021

Uh oh!

openshift-bot commented Jun 3, 2021

Uh oh!

elmiko left a comment

Choose a reason for hiding this comment

Uh oh!

elmiko Jun 29, 2021

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Jul 30, 2021

Uh oh!

openshift-ci Bot commented Jul 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Danil-Grigorev commented Sep 16, 2020 •

edited

Loading