Bug 1878040: operator/network: unify defaulting with OperatorSpec log level#754
Conversation
openshift-ci-robot
added
the
approved
sttts
changed the title
|
/assign @danwinship |
sttts
force-pushed
the
sttts-loglevel-network
branch
from
0df103b to
bfdde78
Compare
sttts
changed the title
openshift-ci-robot
added
the
bugzilla/severity-high
|
@sttts: This pull request references Bugzilla bug 1878040, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@sttts: This pull request references Bugzilla bug 1878040, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
1 similar comment
|
@sttts: This pull request references Bugzilla bug 1878040, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
sttts
force-pushed
the
sttts-loglevel-network
branch
3 times, most recently
from
023181b to
19d0ec4
Compare
Note, that this type is already broken once it is revendored into network operator: it got the enum and the enum does not allow typos. Hence, we need support in the normalization controller in 4.6 and 4.5, cc @vareti.
sttts
force-pushed
the
sttts-loglevel-network
branch
from
19d0ec4 to
c82088e
Compare
|
I don't really understand this, but if you say so. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danwinship, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sttts: Some pull requests linked via external trackers have merged: The following pull requests linked via external trackers have not merged: These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state. Bugzilla bug 1878040 has not been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
Note, that this type is already broken once it is revendored into network operator: it got the enum and the enum does not allow typos. Hence, we need support in the normalization controller in 4.6 and 4.5, cc @vareti.The loglevel normalization controller already had operator.openshift.io/v1 networks in the list: https://github.com/openshift/cluster-config-operator/pull/150/files#diff-5f3b7bf7ad57a65830a8559927ac7c05R108