Add EquinixMetal config api types#784
Conversation
|
Hi @detiber. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
elmiko
left a comment
There was a problem hiding this comment.
this seems mostly reasonable to me, i just have a question about one of the kubebuilder comments.
elmiko
left a comment
There was a problem hiding this comment.
thanks Jason, that was the only thing that looked odd to me.
/lgtm
|
/approve /hold |
|
Rebased to resolve conflict |
|
Development branch has re-opened. /hold cancel |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, detiber, elmiko, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This PR contains changes needed to facilitate Equinix Metal support for machine-api-operator