verify: add require api-approved.openshift.io annotation to all CRD's#931
Merged
Merged
Conversation
openshift-ci
Bot
added
the
approved
sttts
reviewed
May 27, 2021
Contributor
|
Forgot to add the verify target? |
Contributor
Author
victim of |
mfojtik
force-pushed
the
verify-crds
branch
2 times, most recently
from
616d405 to
f5e8d31
Compare
sttts
reviewed
May 27, 2021
Contributor
|
/lgtm |
mfojtik
added
the
bugzilla/valid-bug
Contributor
Author
|
(adding valid-bug manually as this is not bug fix) |
Contributor
|
/hold until all CRDs are verified |
openshift-ci
Bot
added
the
do-not-merge/hold
Contributor
Author
|
/retest |
1 similar comment
Contributor
Author
|
/retest |
Contributor
|
/lgtm |
Contributor
|
/hold cancel |
openshift-ci
Bot
added
lgtm
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kikisdeliveryservice
added a commit
to kikisdeliveryservice/api
that referenced
this pull request
Nov 30, 2021
Annotation required in openshift/api repo as of May 2021. See: openshift#931
kikisdeliveryservice
added a commit
to kikisdeliveryservice/api
that referenced
this pull request
Dec 1, 2021
Annotation required in openshift/api repo as of May 2021. See: openshift#931
jkyros
pushed a commit
to jkyros/api
that referenced
this pull request
Jan 12, 2023
Annotation required in openshift/api repo as of May 2021. See: openshift#931
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From now on, every CRD included in this repository will require to have the
api-approved.openshift.ioannotation that is set to a pull request URL where that CRD was introduced.This follows upstream pattern of https://github.com/kubernetes/enhancements/blob/0e4d5df19d396511fe41ed0860b0ab9b96f46a2d/keps/sig-api-machinery/2337-k8s.io-group-protection/README.md
This is to make sure that every
*.openshift.ioCRD in OCP is coming from this repository.As a follow-up to this, there will be an e2e test that makes sure every
openshift.ioCRD in the cluster has this annotation set.NOTE: The normalization of existing CRD's is a consequence of
oc annotatebug where in addition to annotation the YAML file is normalized as well. These are just reshuffles and should cause no harm to CRD's.