Add CISInstanceCRN to IBMCloudPlatformStatus#951
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom Jun 25, 2021
Merged
Add CISInstanceCRN to IBMCloudPlatformStatus#951openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
CISInstanceCRN is the Cloud Resource Name (CRN) referencing the instance of IBM Cloud Internet Services that is setup to manage the DNS zone of the cluster's base domain. This can be guaranteed in an IPI/UPI installation since this configuration is a pre-requisite. Components like the Cluster Ingress Operator will use this CRN in API calls to update DNS records.
Contributor
Contributor
Contributor
|
This needs review from the owning team first. |
Contributor
|
@deads2k can you approve/merge? that will help us with work that is dependent on this. thank you |
Contributor
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: BobbyRadford, staebler, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CISInstanceCRN is the Cloud Resource Name (CRN) referencing the instance of IBM Cloud Internet Services that is setup to manage the DNS zone of the cluster's base domain. This can be guaranteed in an IPI/UPI installation since this configuration is a pre-requisite. Components like the Cluster Ingress Operator will use this CRN in API calls to update DNS records.
This PR is required to implement IBMCloud IPI/UPI.
Enhancement doc: openshift/enhancements#773
Relevant Installer PR: openshift/installer#4923