Tech Preview Shared Resource CSI Driver by adambkaplan · Pull Request #982 · openshift/api

adambkaplan · 2021-07-29T17:43:20Z

Add the CSIDriverSharedResource feature gate to the tech preview set.
The CSI driver allows Secrets and ConfigMaps to be shared across
namespaces. This driver should only be installed on clusters that opt
into tech preview features.

openshift-ci · 2021-07-29T17:43:26Z

@adambkaplan: This pull request references Bugzilla bug 1986557, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jitendar-singh

Details

In response to this:

Bug 1986557: Tech Preview Shared Resource CSI Driver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

adambkaplan · 2021-07-29T17:46:38Z

/cc @jitendar-singh @rolfedh @RickJWagner

Build + Jenkins team is a no feature freeze team. We intend to make the Shared Resource CSI driver (formerly the Projected Resource CSI driver) available on a tech preview basis. Per the No FF process, we need acks from QE, Docs, and PX

adambkaplan · 2021-07-29T17:47:07Z

/hold

for No FF - hold can be cancelled once qe, docs, and PX sign off.

adambkaplan · 2021-07-29T19:14:34Z

/label docs-approved

^^^ fyi @rolfedh this is how to add the "docs approved" label ^^^

rolfedh · 2021-07-30T08:33:32Z

/label docs-approved

adambkaplan · 2021-08-02T19:30:56Z

/label px-approved

Spoke with @RickJWagner on this - he agreed that we won't need anything beyond product docs to enable end users for this CSI driver.

adambkaplan · 2021-08-03T13:22:10Z

/label qe-approved

QE is able to accept this.

adambkaplan · 2021-08-03T13:22:18Z

/hold cancel

adambkaplan

/hold

The related components won't be in the OCP payload until 4.10

openshift-ci · 2021-08-16T18:32:35Z

@adambkaplan: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

Tech Preview Shared Resource CSI Driver

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2021-09-10T16:31:01Z

master branch has switched to 4.10

/hold cancel

Add the `CSIDriverSharedResource` feature gate to the tech preview set. The CSI driver allows Secrets and ConfigMaps to be shared across namespaces. This driver should only be installed on clusters that opt into tech preview features.

adambkaplan

@openshift/api-reviewers this PR is related to #979. We intend to use a feature gate to ensure the Shared Resource CSI driver is installed on clusters that enable tech preview features.

adambkaplan · 2021-09-20T18:52:12Z

Pull request which utilizes the CSIDriverSharedResource feature gate: openshift/cluster-storage-operator#198

deads2k · 2021-09-20T19:06:55Z

/lgtm

openshift-ci · 2021-09-20T19:08:34Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, deads2k, rolfedh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [deads2k]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci Bot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 29, 2021

openshift-ci Bot requested review from jitendar-singh, mfojtik and smarterclayton July 29, 2021 17:43

openshift-ci Bot requested review from RickJWagner and rolfedh July 29, 2021 17:46

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 29, 2021

rolfedh approved these changes Jul 29, 2021

View reviewed changes

openshift-ci Bot added the docs-approved Signifies that Docs has signed off on this PR label Jul 29, 2021

openshift-ci Bot added the px-approved Signifies that Product Support has signed off on this PR label Aug 2, 2021

adambkaplan mentioned this pull request Aug 2, 2021

BUILD-284: Relocate shared resources api into openshift/api repository #979

Merged

openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Aug 3, 2021

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 3, 2021

adambkaplan commented Aug 16, 2021

View reviewed changes

adambkaplan changed the title ~~Bug 1986557: Tech Preview Shared Resource CSI Driver~~ Tech Preview Shared Resource CSI Driver Aug 16, 2021

openshift-ci Bot removed the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Aug 16, 2021

openshift-ci Bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Aug 16, 2021

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 1, 2021

gabemontero mentioned this pull request Sep 8, 2021

BUILD-281: add feature gate, OCM configuration bit, to enable build csi volume tech preview #1007

Merged

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 10, 2021

Tech Preview Shared Resource CSI Driver

6ce157d

Add the `CSIDriverSharedResource` feature gate to the tech preview set. The CSI driver allows Secrets and ConfigMaps to be shared across namespaces. This driver should only be installed on clusters that opt into tech preview features.

adambkaplan force-pushed the gate-build-csi-features branch from 82e8aba to 6ce157d Compare September 20, 2021 18:38

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 20, 2021

adambkaplan commented Sep 20, 2021

View reviewed changes

openshift-ci Bot assigned deads2k Sep 20, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Sep 20, 2021

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2021

openshift-merge-robot merged commit 319827a into openshift:master Sep 20, 2021

Conversation

adambkaplan commented Jul 29, 2021

Uh oh!

openshift-ci Bot commented Jul 29, 2021

Uh oh!

adambkaplan commented Jul 29, 2021

Uh oh!

adambkaplan commented Jul 29, 2021

Uh oh!

adambkaplan commented Jul 29, 2021

Uh oh!

rolfedh commented Jul 30, 2021

Uh oh!

adambkaplan commented Aug 2, 2021

Uh oh!

adambkaplan commented Aug 3, 2021

Uh oh!

adambkaplan commented Aug 3, 2021

Uh oh!

adambkaplan left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Aug 16, 2021

Uh oh!

gabemontero commented Sep 10, 2021

Uh oh!

adambkaplan left a comment

Choose a reason for hiding this comment

Uh oh!

adambkaplan commented Sep 20, 2021

Uh oh!

deads2k commented Sep 20, 2021

Uh oh!

openshift-ci Bot commented Sep 20, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants