NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.4#2046
NO-ISSUE: Update module github.com/golangci/golangci-lint to v2.11.4#2046red-hat-konflux[bot] wants to merge 1 commit intomasterfrom
Conversation
|
@red-hat-konflux[bot]: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 1 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@Dockerfile.assisted-installer-build`:
- Line 5: The Dockerfile RUN that downloads and executes the golangci-lint
installer uses the mutable master branch URL (the curl | sh pipeline) while
installing v2.11.1; change the download URL in that RUN line to a pinned,
immutable release URL for v2.11.1 (e.g., the raw file or releases/download path
for tag v2.11.1) so the installer script matches the version being installed
(and optionally add a checksum verification step), keeping the rest of the
invocation (-s -- -b $(go env GOPATH)/bin v2.11.1) unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 8b390c51-39dc-4adb-9e60-50a3092d3146
📒 Files selected for processing (1)
Dockerfile.assisted-installer-build
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit 9fe58e5 to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## master #2046 +/- ##
=======================================
Coverage 48.82% 48.82%
=======================================
Files 20 20
Lines 4397 4397
=======================================
Hits 2147 2147
Misses 2026 2026
Partials 224 224 🚀 New features to boost your workflow:
|
3463ba0 to
c5e8ea7
Compare
|
New changes are detected. LGTM label has been removed. |
c5e8ea7 to
4ebd824
Compare
There was a problem hiding this comment.
♻️ Duplicate comments (1)
Dockerfile.assisted-installer-build (1)
5-5:⚠️ Potential issue | 🟠 MajorPin
install.shto the same golangci-lint tag.Line 5 still downloads the installer from
masterwhile installingv2.11.2. That keeps the build non-reproducible and weakens supply-chain guarantees because the script can change independently of the versioned artifact.🔧 Proposed hardening
-RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v2.11.2 && \ +RUN curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/v2.11.2/install.sh | sh -s -- -b "$(go env GOPATH)/bin" v2.11.2 && \#!/bin/bash set -euo pipefail echo "=== Dockerfile line ===" sed -n '5p' Dockerfile.assisted-installer-build echo echo "=== Compare installer scripts ===" for ref in master v2.11.2; do url="https://raw.githubusercontent.com/golangci/golangci-lint/${ref}/install.sh" curl -fsSL "$url" -o "/tmp/golangci-${ref}.sh" printf '%s sha256=%s size=%s\n' \ "$ref" \ "$(sha256sum "/tmp/golangci-${ref}.sh" | awk '{print $1}')" \ "$(wc -c < "/tmp/golangci-${ref}.sh")" done echo if cmp -s /tmp/golangci-master.sh /tmp/golangci-v2.11.2.sh; then echo "master and v2.11.2 install.sh are identical" else echo "master and v2.11.2 install.sh differ" diff -u /tmp/golangci-v2.11.2.sh /tmp/golangci-master.sh | sed -n '1,40p' fi🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@Dockerfile.assisted-installer-build` at line 5, The Dockerfile downloads the golangci-lint installer from master while installing v2.11.2, which makes the build non-reproducible; update the curl invocation that currently fetches "https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh" so it references the matching tag (v2.11.2) instead of master (e.g., use the URL with the v2.11.2 ref) so the installer script and the installed version are pinned together in the RUN line that calls install.sh and sh -s -- -b $(go env GOPATH)/bin v2.11.2.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Duplicate comments:
In `@Dockerfile.assisted-installer-build`:
- Line 5: The Dockerfile downloads the golangci-lint installer from master while
installing v2.11.2, which makes the build non-reproducible; update the curl
invocation that currently fetches
"https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh" so
it references the matching tag (v2.11.2) instead of master (e.g., use the URL
with the v2.11.2 ref) so the installer script and the installed version are
pinned together in the RUN line that calls install.sh and sh -s -- -b $(go env
GOPATH)/bin v2.11.2.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: fcd259cb-b2a2-4c58-921f-c9663df4a568
📒 Files selected for processing (1)
Dockerfile.assisted-installer-build
4ebd824 to
8436634
Compare
a29d9be to
48c19da
Compare
d1a8c90 to
a4f0c35
Compare
a4f0c35 to
c582140
Compare
c582140 to
ea4fb66
Compare
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
1 similar comment
|
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@red-hat-konflux[bot]: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This PR contains the following updates:
v2.8.0→v2.11.4Release Notes
golangci/golangci-lint (github.com/golangci/golangci-lint)
v2.11.4Compare Source
Released on 2026-03-22
govet-modernize: from 0.42.0 to 0.43.0noctx: from 0.5.0 to 0.5.1sqlclosecheck: from 0.5.1 to 0.6.0v2.11.3Compare Source
Released on 2026-03-10
gosec: from v2.24.7 to619ce21v2.11.2Compare Source
Released on 2026-03-07
fmt: fix error when using thefmtcommand with explicit paths.v2.11.1Compare Source
Released on 2026-03-06
Due to an error related to AUR, some artifacts of the v2.11.0 release have not been published.
This release contains the same things as v2.11.0.
v2.11.0Compare Source
Released on 2026-03-06
errcheck: from 1.9.0 to 1.10.0 (excludecrypto/rand.Readby default)gosec: from 2.23.0 to 2.24.6 (new rules:G113,G118,G119,G120,G121,G122,G123,G408,G707)noctx: from 0.4.0 to 0.5.0 (new detection:httptest.NewRequestWithContext)prealloc: from 1.0.2 to 1.1.0revive: from 1.14.0 to 1.15.0 (var-namingto a new rulepackage-naming)gocognit: from 1.2.0 to 1.2.1gosec: from 2.24.6 to 2.24.7unqueryvet: from 1.5.3 to 1.5.4v2.10.1Compare Source
Released on 2026-02-17
v2.10.0Compare Source
Released on 2026-02-17
ginkgolinter: from 0.22.0 to 0.23.0gosec: from 2.22.11 to 2.23.0 (new rules:G117,G602,G701,G702,G703,G704,G705,G706)staticcheck: from 0.6.1 to 0.7.0godoclint: from 0.11.1 to 0.11.2v2.9.0Compare Source
Released on 2026-02-10
arangolint: from 0.3.1 to 0.4.0 (new rule: detect potential query injections)ginkgolinter: from 0.21.2 to 0.22.0 (support for wrappers)golines: from 0.14.0 to 0.15.0misspell: from 0.7.0 to 0.8.0revive: from v1.13.0 to v1.14.0 (new rules:epoch-naming,use-slices-sort)unqueryvet: from 1.4.0 to 1.5.3 (new options:check-n1,check-sql-injection,check-tx-leaks,allow,custom-rules)wsl_v5: from 5.3.0 to 5.6.0 (new rule:after-block)modernize: from 0.41.0 to 0.42.0prealloc: from 1.0.1 to 1.0.2protogetter: from 0.3.18 to 0.3.20Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.