Skip to content

NO-ISSUE: Modify Konflux YAMLs to ocm-5.0#2118

Open
linoyaslan wants to merge 1 commit intoopenshift:masterfrom
linoyaslan:konflux-changes-to-ocm-5.0-db907b7b-1c73-4ffd-9989-d7a6b95a79a0
Open

NO-ISSUE: Modify Konflux YAMLs to ocm-5.0#2118
linoyaslan wants to merge 1 commit intoopenshift:masterfrom
linoyaslan:konflux-changes-to-ocm-5.0-db907b7b-1c73-4ffd-9989-d7a6b95a79a0

Conversation

@linoyaslan
Copy link
Copy Markdown
Contributor

@linoyaslan linoyaslan commented Apr 28, 2026

/cc @danmanor @gamli75

Summary by CodeRabbit

  • Chores
    • Updated build pipeline configurations to target the 5.0 release version
    • Updated container image metadata labels from 2.17 to 5.0

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 28, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@linoyaslan: This pull request explicitly references no jira issue.

Details

In response to this:

/cc @danmanor @gamli75

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from danmanor and gamli75 April 28, 2026 07:25
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 28, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 00c19a40-7240-45cf-a816-6db100a5666c

📥 Commits

Reviewing files that changed from the base of the PR and between 6f77cf5 and 17136ec.

📒 Files selected for processing (6)
  • .tekton/assisted-installer-acm-ds-5-0-pull-request.yaml
  • .tekton/assisted-installer-acm-ds-5-0-push.yaml
  • .tekton/assisted-installer-controller-acm-ds-5-0-pull-request.yaml
  • .tekton/assisted-installer-controller-acm-ds-5-0-push.yaml
  • Dockerfile.assisted-installer-controller-mce
  • Dockerfile.assisted-installer-mce

Walkthrough

This pull request updates release pipeline configurations and Docker image metadata from version 2.17 to 5.0, changing Tekton pipeline identifiers, branch targets, AppStudio labels, image repositories, service accounts, and container metadata labels across assisted-installer and assisted-installer-controller components.

Changes

Cohort / File(s) Summary
Tekton assisted-installer pipelines
.tekton/assisted-installer-acm-ds-5-0-pull-request.yaml, .tekton/assisted-installer-acm-ds-5-0-push.yaml
Updated pipeline names, CEL branch filter from release-ocm-2.17 to release-ocm-5.0, AppStudio application/component labels, output image repository/tag path, and service account references to acm-ds-5-0 variant. Push pipeline also updates Slack notification message with Konflux 5.0 URL.
Tekton assisted-installer-controller pipelines
.tekton/assisted-installer-controller-acm-ds-5-0-pull-request.yaml, .tekton/assisted-installer-controller-acm-ds-5-0-push.yaml
Updated PipelineRun names, CEL branch filter from release-ocm-2.17 to release-ocm-5.0, AppStudio application/component labels, output image repository/tag path, and service account references to acm-ds-5-0 variant. Push pipeline also updates Slack webhook notification message with Konflux 5.0 URL.
Docker image metadata
Dockerfile.assisted-installer-mce, Dockerfile.assisted-installer-controller-mce
Updated container cpe label from multicluster_engine:2.17 to multicluster_engine:5.0.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 12
✅ Passed checks (12 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and specifically describes the primary change: updating Konflux YAML configuration files to target the OCM 5.0 release branch instead of the previous 2.17 version.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR #2118 only modifies Tekton pipeline YAML and Dockerfile files to update version references; no Ginkgo test files are changed, making this check not applicable.
Test Structure And Quality ✅ Passed PR contains only Tekton YAML and Dockerfile changes with no Ginkgo test code modifications, making this test-focused custom check not applicable.
Microshift Test Compatibility ✅ Passed PR does not add or modify any Ginkgo e2e tests; changes are limited to Tekton pipeline configuration and Dockerfile metadata updates.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only Tekton pipeline YAML and Dockerfile labels for version update; no Ginkgo e2e tests added or modified.
Topology-Aware Scheduling Compatibility ✅ Passed PR modifies only CI/CD Tekton pipeline configuration files and Dockerfile metadata labels, which do not affect pod scheduling constraints or topology-aware deployment.
Ote Binary Stdout Contract ✅ Passed PR modifies only Tekton YAML configs and Dockerfile labels, not Go source code, so OTE Binary Stdout Contract check is inapplicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed This PR modifies Tekton pipeline configuration and Dockerfile labels only, with no new or modified Ginkgo e2e tests added.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. downstream-change-needed Requires updating downstream image labels Apr 28, 2026
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: linoyaslan
Once this PR has been reviewed and has the lgtm label, please assign rccrdpccl for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.82%. Comparing base (6f77cf5) to head (17136ec).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2118   +/-   ##
=======================================
  Coverage   48.82%   48.82%           
=======================================
  Files          20       20           
  Lines        4397     4397           
=======================================
  Hits         2147     2147           
  Misses       2026     2026           
  Partials      224      224           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 28, 2026

@linoyaslan: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

downstream-change-needed Requires updating downstream image jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants