Add dynkeepalived to solve interface changes#20
Merged
celebdor merged 1 commit intoopenshift:masterfrom Sep 20, 2019
Merged
Conversation
Using runtimecfg render for keepalived has the issue that on 1.x keepalived versions there's no dynamic interfaces and in case the interface changes, keepalived will stop doing its job. Thanks to dynkeepalived, it is now possible to have it monitor the interface and dynamically send a reload to a unix socket that can be used to trigger a keepalived reload in the keepalived container. This is meant to be used from a side-car to the keepalived pod. Signed-off-by: Antoni Segura Puimedon <antoni@redhat.com>
openshift-ci-robot
added
size/L
Contributor
Author
|
/hold Needs proper regression testing on the monitor and the runtimecfg binaries. |
openshift-ci-robot
added
the
do-not-merge/hold
phoracek
approved these changes
Sep 18, 2019
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: celebdor, phoracek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Contributor
Author
|
Did manual testing of the binaries and made a successful deployment to rule out regressions. Pending to verify dynkeepalived once nmstate triggers, @phoracek |
Contributor
Author
|
Verified with success that the IP was moved to brext and the VIPs did as well. The downtime for reconfiguration of the interfaces was of about 90seconds. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using runtimecfg render for keepalived has the issue that on 1.x
keepalived versions there's no dynamic interfaces and in case the
interface changes, keepalived will stop doing its job.
Thanks to dynkeepalived, it is now possible to have it monitor the
interface and dynamically send a reload to a unix socket that can be
used to trigger a keepalived reload in the keepalived container.
This is meant to be used from a side-car to the keepalived pod.
Signed-off-by: Antoni Segura Puimedon antoni@redhat.com