Bug 1946363: move entitlement related secrets back to mounts.conf by gabemontero · Pull Request #242 · openshift/builder

gabemontero · 2021-04-05T21:18:02Z

manual pick of #240 required

among other things, I got this error running make test, go mod tidy, go mod vendor

verifying github.com/openshift/source-to-image@v1.3.0: checksum mismatch
	downloaded: h1:YDEH0PY0sMaUNbpJAGnDZA94tkAD6qi1Rou8ycWRPRc=
	go.sum:     h1:ZktIgJ85Vn0HOyHdS6uQOMXhmYwc5h76w/6LpnJ60L8=

SECURITY ERROR
This download does NOT match an earlier download recorded in go.sum.
The bits may have been replaced on the origin server, or an attacker may
have intercepted the download attempt.

For more information, see 'go help module-auth'.

so there is a separate commit to fix go.sum and make the noted commands happy

/assign @adambkaplan

openshift-ci-robot · 2021-04-05T21:18:07Z

@gabemontero: This pull request references Bugzilla bug 1946363, which is invalid:

expected dependent Bugzilla bug 1945692 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
expected dependent Bugzilla bug 1940488 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1946363: move entitlement related secrets back to mounts.conf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-04-05T21:20:07Z

@gabemontero: This pull request references Bugzilla bug 1946363, which is invalid:

expected dependent Bugzilla bug 1945692 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
expected dependent Bugzilla bug 1940488 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1946363: move entitlement related secrets back to mounts.conf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wewang58 · 2021-04-07T09:40:41Z

/bugzilla cc-qa
Today cannot install upi clusters, jenkins is down, will do it tomorrow

openshift-ci-robot · 2021-04-07T09:40:47Z

@wewang58: This pull request references Bugzilla bug 1946363, which is invalid:

expected dependent Bugzilla bug 1945692 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is POST instead
expected dependent Bugzilla bug 1940488 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla cc-qa
Today cannot install upi clusters, jenkins is down, will do it tomorrow

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wewang58 · 2021-04-09T12:04:58Z

Tested it using cluster-bot, verify it
/lgtm

wewang58 · 2021-04-09T12:05:08Z

/label qe-approved

openshift-bot · 2021-04-10T01:00:26Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-10T01:00:32Z

@openshift-bot: This pull request references Bugzilla bug 1946363, which is invalid:

expected dependent Bugzilla bug 1945692 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
expected dependent Bugzilla bug 1940488 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-11T01:00:25Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-11T01:00:29Z

@openshift-bot: This pull request references Bugzilla bug 1946363, which is invalid:

expected dependent Bugzilla bug 1945692 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
expected dependent Bugzilla bug 1940488 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-12T01:00:20Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-12T01:00:25Z

@openshift-bot: This pull request references Bugzilla bug 1946363, which is invalid:

expected dependent Bugzilla bug 1945692 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is ON_QA instead
expected dependent Bugzilla bug 1940488 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-04-13T01:00:52Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2021-04-13T01:00:57Z

@openshift-bot: This pull request references Bugzilla bug 1946363, which is invalid:

expected dependent Bugzilla bug 1940488 to target a release in 4.7.0, 4.7.z, but it targets "4.8.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2021-04-13T01:14:08Z

/bugzilla refresh

openshift-ci-robot · 2021-04-13T01:14:13Z

@gabemontero: This pull request references Bugzilla bug 1946363, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1945692 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1945692 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
bug has dependents

Requesting review from QA contact:
/cc @wewang58

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2021-04-13T01:15:25Z

bump @adambkaplan need an approve label for this 4.6 PR for the host entitlements fix

adambkaplan

/approve

openshift-ci-robot · 2021-04-13T12:18:14Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero, wewang58

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

mfojtik · 2021-04-15T11:56:49Z

[patch-manager] 🚀 Approved for z-stream by score: 1.00

openshift-ci-robot · 2021-04-15T13:50:43Z

@gabemontero: All pull requests linked via external trackers have merged:

openshift/builder#242

Bugzilla bug 1946363 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1946363: move entitlement related secrets back to mounts.conf

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero added 2 commits April 5, 2021 16:51

move entitlement related secrets back to mounts.conf

012d6b9

fix go.sum download mismatch for s2i

4a2303c

openshift-ci-robot assigned adambkaplan Apr 5, 2021

openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 5, 2021

openshift-ci-robot requested review from adambkaplan and coreydaley April 5, 2021 21:18

openshift-ci-robot added the qe-approved Signifies that QE has signed off on this PR label Apr 9, 2021

openshift-ci-robot assigned wewang58 Apr 9, 2021

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 9, 2021

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Apr 13, 2021

openshift-ci-robot requested a review from wewang58 April 13, 2021 01:14

adambkaplan approved these changes Apr 13, 2021

View reviewed changes

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2021

mfojtik added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Apr 15, 2021

openshift-merge-robot merged commit 263041a into openshift:release-4.6 Apr 15, 2021

gabemontero deleted the fix-host-entilements-46 branch April 15, 2021 14:07

Conversation

gabemontero commented Apr 5, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 5, 2021

Uh oh!

openshift-ci-robot commented Apr 5, 2021

Uh oh!

wewang58 commented Apr 7, 2021

Uh oh!

openshift-ci-robot commented Apr 7, 2021

Uh oh!

wewang58 commented Apr 9, 2021

Uh oh!

wewang58 commented Apr 9, 2021

Uh oh!

openshift-bot commented Apr 10, 2021

Uh oh!

openshift-ci-robot commented Apr 10, 2021

Uh oh!

openshift-bot commented Apr 11, 2021

Uh oh!

openshift-ci-robot commented Apr 11, 2021

Uh oh!

openshift-bot commented Apr 12, 2021

Uh oh!

openshift-ci-robot commented Apr 12, 2021

Uh oh!

openshift-bot commented Apr 13, 2021

Uh oh!

openshift-ci-robot commented Apr 13, 2021

Uh oh!

gabemontero commented Apr 13, 2021

Uh oh!

openshift-ci-robot commented Apr 13, 2021

Uh oh!

gabemontero commented Apr 13, 2021

Uh oh!

adambkaplan left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Apr 13, 2021

Uh oh!

mfojtik commented Apr 15, 2021

Uh oh!

openshift-ci-robot commented Apr 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

gabemontero commented Apr 5, 2021 •

edited

Loading