OCPBUGS-62210: BuildConfig inline Dockerfile fails with heredoc syntax#469
Conversation
When writing out the contents of a parsed Dockerfile, attempt to reproduce heredocs that followed instructions. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
|
Heredocs were first recognized in buildah 1.33, so I expect that this is applicable to release-4.14 and all later branches. |
|
/retest |
The OCP builder API path isn't parsing the heredoc correctly for some
reason:
error: build error: EOF: unterminated heredoc
This will be fixed by openshift/builder#469.
Anyway, just work around this for now by moving all the logic to
scripts. It does make the Containerfiles cleaner at least now that it
has gotten so larger and we get syntax highlighting, ShellCheck, etc...
so probably for the best.
|
We have also been observing this issue within OKD community as well, would appreciate the fix being merged |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
Bot
added
the
lifecycle/stale
|
/lifecycle frozen |
|
@nalind: The DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
But you said! /remove-lifecycle stale |
openshift-ci
Bot
removed
the
lifecycle/stale
|
/retest |
|
/retitle OCPBUGS-62210: BuildConfig inline Dockerfile fails with heredoc syntax |
openshift-ci
Bot
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@nalind: This pull request references Jira Issue OCPBUGS-62210, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: Moebasim. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
@moebasim: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/label docs-approved |
openshift-ci
Bot
added
docs-approved
|
/lgtm |
|
@moebasim: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Moebasim, nalind, prabhapa The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/verified by @kunalmemane |
openshift-ci-robot
added
the
verified
|
@kunalmemane: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/test e2e-aws-ovn-image-ecosystem |
|
That e2e-aws-ovn-image-ecosystem test should be fixed by openshift/origin#30376. |
|
/test e2e-aws-ovn-image-ecosystem |
|
@nalind: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-aws-ovn-image-ecosystem |
openshift-merge-bot
Bot
merged commit c0ef839
into
openshift:main
|
@nalind: Jira Issue Verification Checks: Jira Issue OCPBUGS-62210 Jira Issue OCPBUGS-62210 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/cherrypick release-4.20 |
|
@kunalmemane: new pull request created: #483 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
8 participants
When writing out the contents of a parsed Dockerfile, attempt to reproduce the heredocs that followed instructions. Originally encountered by @jlebon while working on openshift/os#1780.