Skip to content

[release-4.18] OCPBUGS-65655: BuildConfig inline Dockerfile fails with heredoc syntax#486

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.18from
openshift-cherrypick-robot:cherry-pick-485-to-release-4.18
Nov 20, 2025
Merged

[release-4.18] OCPBUGS-65655: BuildConfig inline Dockerfile fails with heredoc syntax#486
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.18from
openshift-cherrypick-robot:cherry-pick-485-to-release-4.18

Conversation

@openshift-cherrypick-robot
Copy link
Copy Markdown

@openshift-cherrypick-robot openshift-cherrypick-robot commented Nov 17, 2025

This is an automated cherry-pick of #485

/assign openshift-cherrypick-robot

/cherrypick release-4.17 release-4.16 release-4.15 release-4.14

@nalind
pkg/build/builder/util/dockerfile.Write: reproduce heredocs
4594e98 
When writing out the contents of a parsed Dockerfile, attempt to
reproduce heredocs that followed instructions.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 17, 2025
Merged
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 17, 2025

@openshift-cherrypick-robot: Jira Issue OCPBUGS-65624 has been cloned as Jira Issue OCPBUGS-65655. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-65655: BuildConfig inline Dockerfile fails with heredoc syntax

Details

In response to this:

This is an automated cherry-pick of #485

/assign openshift-cherrypick-robot

/cherrypick release-4.17 release-4.16 release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.18] OCPBUGS-65624: BuildConfig inline Dockerfile fails with heredoc syntax [release-4.18] OCPBUGS-65655: BuildConfig inline Dockerfile fails with heredoc syntax Nov 17, 2025
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 17, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 17, 2025

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-65655, which is invalid:

  • expected dependent Jira Issue OCPBUGS-65624 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is an automated cherry-pick of #485

/assign openshift-cherrypick-robot

/cherrypick release-4.17 release-4.16 release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 17, 2025

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 4594e98 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@moebasim
Copy link
Copy Markdown
Contributor

moebasim commented Nov 18, 2025

/verified by @moebasim

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 18, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 18, 2025

@moebasim: This PR has been marked as verified by @Moebasim.

Details

In response to this:

/verified by @moebasim

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@moebasim
Copy link
Copy Markdown
Contributor

moebasim commented Nov 18, 2025

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Nov 18, 2025
@moebasim
Copy link
Copy Markdown
Contributor

moebasim commented Nov 18, 2025

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 18, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Moebasim, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 18, 2025
@kunalmemane
Copy link
Copy Markdown
Member

kunalmemane commented Nov 20, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 20, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 20, 2025

@kunalmemane: This pull request references Jira Issue OCPBUGS-65655, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-65624 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-65624 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
  • bug has dependents

Requesting review from QA contact:
/cc @moebasim

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit c5921ae into openshift:release-4.18 Nov 20, 2025
8 of 9 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Nov 20, 2025

@openshift-cherrypick-robot: Jira Issue Verification Checks: Jira Issue OCPBUGS-65655
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-65655 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is an automated cherry-pick of #485

/assign openshift-cherrypick-robot

/cherrypick release-4.17 release-4.16 release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown
Author

openshift-cherrypick-robot commented Nov 20, 2025

@openshift-cherrypick-robot: new pull request created: #488

Details

In response to this:

This is an automated cherry-pick of #485

/assign openshift-cherrypick-robot

/cherrypick release-4.17 release-4.16 release-4.15 release-4.14

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 20, 2025
Merged
@openshift-merge-robot
Copy link
Copy Markdown
Contributor

openshift-merge-robot commented Nov 22, 2025

Fix included in accepted release 4.18.0-0.nightly-2025-11-22-072148

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@moebasim moebasim Awaiting requested review from moebasim

@sayan-biswas sayan-biswas Awaiting requested review from sayan-biswas

Assignees

@moebasim moebasim

@openshift-cherrypick-robot openshift-cherrypick-robot

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @openshift-ci-robot @moebasim @kunalmemane @openshift-merge-robot @nalind