This repository was archived by the owner on Jun 14, 2019. It is now read-only.
Allow images to be excluded from promotion, no matter what #254
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some test environments may wish to build an image and put it in the
payload for testing, but not promote that image. An example of this
is the new machine-os-content image that will be built for RHCoS -
a few projects like origin and crio need to be able to take the
existing machine-os-content as a prereq, layer on top of it their
test RPMs, and then verify the complete payload as an e2e test (i.e.
test RHCoS with their latest code). Since this image is test only,
we need a clean way to indicate it's not for promotion, but we
want to build it every time we build the payload.
This will also be simpler for folks to reason about than optional,
which was really only for artifact style images that currently
aren't ever tested or added than the payload.
In promotion config, add:
excluded_images:
- image-1
- image-2
- ...
and the referenced images will never be promoted.
openshift-ci-robot
added
the
size/S
Member
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: droslean, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
smarterclayton
added a commit
to smarterclayton/release
that referenced
this pull request
Feb 3, 2019
The machine-os-content image is injected into our CI stream containing a snapshot of recent openshift projects (kubelet, crio, oc). To ensure we are testing what we merge, this PR adds a new layer job to origin that takes the current machine-os-content image and uses it as input to a special layering Dockerfile defined in origin which injects the version of the kubelet and oc binaries from the PR build. The machine-os-content image is then overriden in stable, but is not promoted using the new exclusion rule in openshift/ci-operator#254. This will be the model for crio or any other RPM that doesn't require special boot time changes (like ignition or the kernel would). However, this allows us to test upgrades like they will actually happen in the wild. This will be merged after the ci-operator change, and after the dockerfile merges to origin, but before the machine-config-operator starts respecting the payload image (and causes reboots when machine start up).
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some test environments may wish to build an image and put it in the
payload for testing, but not promote that image. An example of this
is the new machine-os-content image that will be built for RHCoS -
a few projects like origin and crio need to be able to take the
existing machine-os-content as a prereq, layer on top of it their
test RPMs, and then verify the complete payload as an e2e test (i.e.
test RHCoS with their latest code). Since this image is test only,
we need a clean way to indicate it's not for promotion, but we
want to build it every time we build the payload.
This will also be simpler for folks to reason about than optional,
which was really only for artifact style images that currently
aren't ever tested or added than the payload.
In promotion config, add:
and the referenced images will never be promoted.
Part of enabling RHCoS content images to be layered during CI
runs so we test kubelet from an origin PR with the OS base image
in the payload.