Skip to content
This repository was archived by the owner on Jun 14, 2019. It is now read-only.

Conversation

@smarterclayton
Copy link
Contributor

When we tag images in, create a second image stream stable-initial
that will not be modified and then let a secondary task create an
image stream from that alternate source. If RELEASE_IMAGE_INITIAL
is already specified, skip the action and instead tag it to that
location.

Simplify the structure of the AssembleReleaseStep to handle
both initial and latest.

Makes it easy to test an upgrade from the previous state to the
current state (post change) while also allowing for injecting an
initial step.

Fixed from revert in #290, was caused by this line:

	return fmt.Sprintf("[release:%s]", strings.ToUpper(s.tag()))

should be

	return fmt.Sprintf("[release:%s]", s.tag())

and caused [release:LATEST] to not be available to target from
--target [release:latest] like the job does.

When we tag images in, create a second image stream `stable-initial`
that will not be modified and then let a secondary task create an
image stream from that alternate source. If RELEASE_IMAGE_INITIAL
is already specified, skip the action and instead tag it to that
location.

Simplify the structure of the AssembleReleaseStep to handle
both initial and latest.

Makes it easy to test an upgrade from the previous state to the
current state (post change) while also allowing for injecting an
initial step.
@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Mar 6, 2019
@stevekuznetsov
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton, stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [smarterclayton,stevekuznetsov]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 70edfc7 into openshift:master Mar 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants