This repository was archived by the owner on Jun 14, 2019. It is now read-only.
Use a multithreaded python server to serve RPMs #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimpleHTTPServer is single threaded and so a long download will cause liveness checks to fail. This is a more complicated variant that runs multiple threads.
openshift-ci-robot
added
the
size/M
Contributor
|
I wish I never saw this :O |
wking
added a commit
to wking/console-operator
that referenced
this pull request
Mar 16, 2019
We need to support the ability to download clients (oc) from the cluster when an install is successful. With this commit, I'm adding a new Deployment for serving the binary from the cli image referenced from the release image. That way, the provided oc is the appropriate version for the current cluster version. I've set 'replicas' to two to support continued availability during rolling updates. The Python here-document approach is based on openshift/ci-operator@95a41a39 (Use a multithreaded python server to serve RPMs, 2018-06-25, openshift/ci-operator#35). The script creates a scratch directory to serve from, and populates it with the oc binary (via a symlink). It also creates zip and tar versions, so users can do things like: $ wget https://downloads-openshift-console.apps.wking.devcluster.openshift.com/amd64/linux/oc.zip $ unzip oc.zip instead of: $ wget https://downloads-openshift-console.apps.wking.devcluster.openshift.com/amd64/linux/oc $ chmod +x oc if they prefer. We don't have to clean up the scratch directory in the script, because it will be reaped as part of container cleanup. Moving forward, we'll want to replace the cli image with a cli-downloads image that includes builds for other platforms and architectures, but I'm punting on that for now. [1]: openshift/ci-operator@95a41a3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SimpleHTTPServer is single threaded and so a long download will cause
liveness checks to fail. This is a more complicated variant that runs
multiple threads.
@stevekuznetsov
Tested manually, verified shutdown is clean, ran a load test against it.