Skip to content

Revert "prowgen: generate stricter branch: stanzas for presubmits"#2150

Closed
droslean wants to merge 1 commit intoopenshift:masterfrom
droslean:revert-2136-stricter-feature-branches
Closed

Revert "prowgen: generate stricter branch: stanzas for presubmits"#2150
droslean wants to merge 1 commit intoopenshift:masterfrom
droslean:revert-2136-stricter-feature-branches

Conversation

@droslean
Copy link
Copy Markdown
Member

@droslean droslean commented Jul 8, 2021

Reverts #2136

This change generates jobs with multiple branches which broke the rehearse tool.

    branches:
    - ^master$
    - ^master-

/hold

Shall we revert or patch the rehearse tool to work with multiple branches?

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2021
@droslean
Copy link
Copy Markdown
Member Author

droslean commented Jul 8, 2021

/cc @openshift/openshift-team-developer-productivity-test-platform

@openshift-ci openshift-ci Bot requested a review from a team July 8, 2021 11:30
@droslean
Copy link
Copy Markdown
Member Author

droslean commented Jul 8, 2021

/hold
Maybe #2151 ?

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 8, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 8, 2021

@droslean: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/breaking-changes 6e5ba7d link /test breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@droslean
Copy link
Copy Markdown
Member Author

droslean commented Jul 8, 2021

/close

@bbguimaraes
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 8, 2021

@droslean: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot closed this Jul 8, 2021
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 8, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jul 8, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bbguimaraes, droslean

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [bbguimaraes,droslean]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@droslean
Copy link
Copy Markdown
Member Author

droslean commented Jul 8, 2021

/open

@droslean droslean deleted the revert-2136-stricter-feature-branches branch July 8, 2021 11:59
@droslean droslean restored the revert-2136-stricter-feature-branches branch July 8, 2021 11:59
@droslean droslean deleted the revert-2136-stricter-feature-branches branch July 8, 2021 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants