test/e2e: relax pending test check#3398
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom May 2, 2023
Merged
test/e2e: relax pending test check#3398openshift-merge-robot merged 1 commit intoopenshift:masterfrom
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
This test is meant to cause a pending timeout using a non-existent image. It works as intended, but it intentionally uses a short timeout period so that it executes quickly. It may happen that the timeout happens for other reasons (this is after all what the actual verification is meant to detect), leading to test failures such as the one seen here: openshift#3390 (comment) Since the reason for the delay is not relevant for this test, only that it be detected and properly reported, this change relaxes the error message searched in the logs such that any pending situation satisfies the test.
bbguimaraes
force-pushed
the
e2e_pending
branch
from
8f91f65 to
7571a4f
Compare
openshift-ci
Bot
added
the
approved
Contributor
|
@bbguimaraes: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bbguimaraes, danilo-gemoli The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test is meant to cause a pending timeout using a non-existent image. It
works as intended, but it intentionally uses a short timeout period so that it
executes quickly. It may happen that the timeout happens for other reasons
(this is after all what the actual verification is meant to detect), leading to
test failures such as the one seen here:
#3390 (comment)
Since the reason for the delay is not relevant for this test, only that it be
detected and properly reported, this change relaxes the error message searched
in the logs such that any pending situation satisfies the test.