Skip to content

Conversation

@deepsm007
Copy link
Contributor

@deepsm007 deepsm007 commented Oct 15, 2025

Add AllowPrePostStepOverrides to MultiStageTestConfiguration.
mergeWorkflow now validates pre/post overrides, requiring the flag set to true to prevent accidental resource leaks. Updated YAML docs and added comprehensive tests.

https://issues.redhat.com/browse/DPTP-4575

/cc @openshift/test-platform

@openshift-ci openshift-ci bot requested a review from a team October 15, 2025 14:23
@deepsm007 deepsm007 changed the title Restrict/warn overridding of pre/post definitions in tests Overridding of pre/post definitions in tests requires manual flag Oct 15, 2025
@deepsm007
Copy link
Contributor Author

/ai pr_description

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 15, 2025

@deepsm007:
Add AllowPrePostStepOverrides to MultiStageTestConfiguration.
mergeWorkflow now validates pre/post overrides, requiring the flag set to true to prevent accidental resource leaks. Updated YAML docs and added comprehensive tests.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 15, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deepsm007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 15, 2025
@deepsm007 deepsm007 force-pushed the DPTP-4575 branch 2 times, most recently from 020aeec to 1501885 Compare October 15, 2025 15:56
@deepsm007
Copy link
Contributor Author

/test images

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2025

@deepsm007: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/breaking-changes 8d3f9a7 link false /test breaking-changes

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The filename is wrong. You need to put them in test_test.go

@openshift-bot
Copy link
Contributor

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 14, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 14, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants