Retire some older conditional edges which required PromQL eval#3590
Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom May 9, 2023
Merged
Conversation
This is to work around the series of bugs where it takes 10mins per `type: PromQL` risk to evaluate in versions prior to 4.12.9, 4.11.34, and 4.10.56. If we reduce the number of outstanding PromQL risks by converting them to Always risks when we've had superseding versions out for quite some time we can improve the user experience.
Contributor
|
@sdodson: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: LalatenduMohanty, sdodson The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
wking
added a commit
to wking/cincinnati-graph-data
that referenced
this pull request
Aug 16, 2023
To mitigate slow cache warming [1], like 9916190 (Retire some older conditional edges which required PromQL eval, 2023-05-09, openshift#3590). The fixedIn 4.13.4 entered stable-4.13 back in June: $ git --no-pager blame channels/stable-4.13.yaml | grep ' 4[.]13[.]4$' 90eca13 (Automated Stabilization Robot 2023-06-29 08:03:38 +0000 40) - 4.13.4 so it's unlikely that there are all that many folks still interested in updating to it, instead of a more recent 4.13.z. And anyone who is interested can still read the message and ticket, decide whether they're exposed, and update if they feel they aren't exposed (or if they feel they are exposed but can handle being bit). Generated with: $ for X in blocked-edges/*PersistentVolumeDiskIDSymlinks*; do CONTENT="$(grep -B100 matchingRules: "${X}"; printf -- '- type: %s\n' Always)"; echo "${CONTENT}" > "${X}"; done [1]: https://issues.redhat.com/browse/OTA-942
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to work around the series of bugs starting with OCPBUGS-10514 where it takes 10mins per unique outstanding
type: PromQLrisk to evaluate in versions prior to 4.12.9, 4.11.34, and 4.10.56. If we reduce the number of outstanding PromQL risks by converting them to Always risks when we've had superseding versions with fixes for those risks we can improve the user experience. FWIW, we've not fixed the throttling to warm in a decent time, we've only updated it so that it evaluates risks on the newest versions first under the assumption that the newest version will have the least conditional updates and we can begin offering updates to the best version as quickly as possible while other, older risks, are being evaluated.All risks modified here have had fixes in superseding versions for no less than six weeks. This gets us back to one outstanding PromQL risk across all channels.
We've done this previously in #2968