Skip to content

MCO-1481: blocked-edges/4.18.0-rc.*-MachineConfigServerCARotation: Declare new risk#6463

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
wking:MachineConfigServerCARotation
Dec 17, 2024
Merged

MCO-1481: blocked-edges/4.18.0-rc.*-MachineConfigServerCARotation: Declare new risk#6463
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
wking:MachineConfigServerCARotation

Conversation

@wking
Copy link
Copy Markdown
Member

@wking wking commented Dec 17, 2024

No description provided.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Dec 17, 2024

@wking: This pull request references MCO-1481 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the spike to target the "4.19.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 17, 2024
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@wking wking force-pushed the MachineConfigServerCARotation branch from 1c92d4a to 5050846 Compare December 17, 2024 17:26
@wking
Copy link
Copy Markdown
Member Author

wking commented Dec 17, 2024

Quay 502 is unrelated.

/test e2e

…risk

We don't have to declare this for updated into 4.19, because 4.19 was
born with rc.0 as it's update floor:

  $ git blame --first-parent build-suggestions/4.19.yaml | head -n2
  11cc1f7 (openshift-merge-bot[bot] 2024-12-05 18:28:06 +0000 1) default:
  11cc1f7 (openshift-merge-bot[bot] 2024-12-05 18:28:06 +0000 2)   minor_min: 4.18.0-rc.0

so ec.4 cannot update directly to any 4.19 releases.
@wking wking force-pushed the MachineConfigServerCARotation branch from 5050846 to 53dc081 Compare December 17, 2024 17:54
Comment thread blocked-edges/4.18.0-rc.0-MachineConfigServerCARotation.yaml
Comment on lines +1 to +2
to: 4.18.0-rc.2
from: 4[.]18[.]0-ec[.]4[+].*
Copy link
Copy Markdown
Contributor

@DavidHurta DavidHurta Dec 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand correctly that we will declare the risk as fixed after z_min in build-suggestions/4.18.yaml is bumped to a version higher than 4.18.0-ec.4 and there are no new upgrade paths from 4.18.0-ec.4, correct?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, we'll declare it fixed by 4.18.1, because at GA-time, we raise that z_min to the GA release.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2024
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: DavidHurta, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants