dist: optimize build script and Dockerfile#22
Conversation
|
@steveej: GitHub didn't allow me to request PR reviews from the following users: riuvshin. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/S
There was a problem hiding this comment.
this will lead to workspace growing with every new build, I would like to overwrite all generated files or clean-up after the build
There was a problem hiding this comment.
Ah, isn't the CI job spawned with a clean workspace?
There was a problem hiding this comment.
no, this one has static slaves.
There was a problem hiding this comment.
I added a cleanup trap, PTAL
This change removes the overhead of sending the whole target directory to the Docker daemon as the build context. Instead we can create a mininum build context which contains only the desired static binaries.
steveej
force-pushed
the
improve-build-deploy
branch
from
7dbf7dc to
fbc9981
Compare
steveej
changed the title
|
[test] |
openshift-ci-robot
added
size/M
steveej
changed the title
|
triggering another build to test if subsequent builds now work. previously it failed to cleanup the workspace cause some leftover files were owned by root. [test] |
| FROM centos:7 | ||
|
|
||
| RUN yum -y groupinstall 'Development Tools' | ||
| RUN yum -y install openssl-devel |
There was a problem hiding this comment.
have you tested resulting image with this?
There was a problem hiding this comment.
I tested the steps from the docker-based stack outlined in #20 and it works as expected
There was a problem hiding this comment.
Ideally our CI would test that ;-)
|
awesome! |
|
[test] |
1 similar comment
|
[test] |
|
/lgtm |
|
@riuvshin: changing LGTM is restricted to assignees, and only openshift/cincinnati repo collaborators may be assigned issues. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I probably can't do it myself either ;-) but let's see /lgtm |
|
@steveej: you cannot LGTM your own PR. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
3 participants
This change removes the overhead of sending the whole target directory
to the Docker daemon as the build context. Instead we can create a
mininum build context which contains only the desired static binaries.
Also removes the obsolete runtime deps.
/cc @riuvshin