introduce openshift template#23
Merged
Merged
Conversation
openshift-ci-robot
added
the
size/L
Contributor
Author
|
[test] |
Contributor
|
Is the path for this file hardcoded somewhere or can we change it? We could move it to dist/openshift-template.yaml |
Contributor
Author
|
@steveej this can be changed, I've moved it to dist |
Contributor
|
Please rebase this onto current master so it doesn't mess up the CI permissions. |
riuvshin
force-pushed
the
master
branch
2 times, most recently
from
35d9eda to
4b3a1e4
Compare
Contributor
Author
|
[test] |
steveej
reviewed
Dec 5, 2018
steveej
approved these changes
Dec 5, 2018
openshift-merge-robot
pushed a commit
that referenced
this pull request
Aug 11, 2022
As defined in [1] and documented in [2]. Unclear to me why the initial empty-group apiVersion had been working, but we'd been using that approach since cfa2c31 (introduce openshift template, cm and secret, 2018-12-05, #23). Adding the group should avoid [3]: + oc process -f dist/openshift/observability.yaml -p NAMESPACE=openshift-update-service error: failed to read input object (not a Template?): resource mapping not found for name: "cincinnati-observability" namespace: "" from "dist/openshift/observability.yaml": no matches for kind "Template" in version "v1" ensure CRDs are installed first and match: $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/31237/rehearse-31237-pull-ci-openshift-cincinnati-master-e2e/1557741650380328960/artifacts/e2e/gather-must-gather/artifacts/must-gather.tar | tar tvz | grep 'cluster-scoped-resources.*template' | grep -v counts -rw------- 1010620000/root 3224 2022-08-11 11:17 quay-io-openshift-release-dev-ocp-v4-0-art-dev-sha256-347d2a0427701d8f358d53ecc3e6b4e5779af090bbce71577fa019255e7f4a21/cluster-scoped-resources/apiregistration.k8s.io/apiservices/v1.template.openshift.io.yaml $ curl -s https://gcsweb-ci.apps.ci.l2s4.p1.openshiftapps.com/gcs/origin-ci-test/pr-logs/pull/openshift_release/31237/rehearse-31237-pull-ci-openshift-cincinnati-master-e2e/1557741650380328960/artifacts/e2e/gather-must-gather/artifacts/must-gather.tar | tar xOz quay-io-openshift-release-dev-ocp-v4-0-art-dev-sha256-347d2a0427701d8f358d53ecc3e6b4e5779af090bbce71577fa019255e7f4a21/cluster-scoped-resources/apiregistration.k8s.io/apiservices/v1.template.openshift.io.yaml | yaml2json | jq -c '.spec | {group, version}' {"group":"template.openshift.io","version":"v1"} [1]: https://github.com/openshift/api/blame/72d2ca90c49733567a5530e42aece2e68bd709ea/template/install.go#L11 [2]: https://docs.openshift.com/container-platform/4.10/rest_api/template_apis/template-template-openshift-io-v1.html [3]: https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_release/31237/rehearse-31237-pull-ci-openshift-cincinnati-master-e2e/1557741650380328960#1:build-log.txt%3A108-110
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
introduce openshift template