Skip to content

OCPBUGS-179: fix conditional edge for type always#730

Merged
PratikMahajan merged 2 commits into
openshift:masterfrom
PratikMahajan:ce-always-fix
Aug 17, 2022
Merged

OCPBUGS-179: fix conditional edge for type always#730
PratikMahajan merged 2 commits into
openshift:masterfrom
PratikMahajan:ce-always-fix

Conversation

@PratikMahajan
Copy link
Copy Markdown
Contributor

@PratikMahajan PratikMahajan commented Aug 17, 2022 •
edited
Loading

conditional edge has an empty promql when the type of
conditional block is Always
This commit skips the serlialization if promql if the
promql condition is empty, which is the case for
type Always

Co-Authored-By: W. Trevor King wking@tremily.us

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2022
@openshift-ci openshift-ci Bot requested review from jottofar and wking August 17, 2022 16:43
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 17, 2022
@PratikMahajan PratikMahajan changed the title [WIP] fix conditional edge for type always fix conditional edge for type always Aug 17, 2022
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2022
@PratikMahajan PratikMahajan changed the title fix conditional edge for type always OCPBUGS-179: fix conditional edge for type always Aug 17, 2022
@openshift-ci-robot openshift-ci-robot added the jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. label Aug 17, 2022
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 17, 2022 •
edited by openshift-ci Bot
Loading

@PratikMahajan: This pull request references [Jira Issue OCPBUGS-179](https://issues.redhat.com//browse/OCPBUGS-179), which is invalid:

  • expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

conditional edge has an empty promql when the type of
conditional block is Always
This commit skips the serlialization if promql if the
promql condition is empty, which is the case for
type Always

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 17, 2022
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 17, 2022 •
edited by openshift-ci Bot
Loading

@PratikMahajan: This pull request references [Jira Issue OCPBUGS-179](https://issues.redhat.com//browse/OCPBUGS-179), which is invalid:

  • expected the bug to target the "4.12.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

conditional edge has an empty promql when the type of
conditional block is Always
This commit skips the serlialization if promql if the
promql condition is empty, which is the case for
type Always

Co-Authored-By: W. Trevor King wking@tremily.us

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wking
wking reviewed Aug 17, 2022
View reviewed changes
Comment thread cincinnati/src/lib.rs Outdated
wking
wking reviewed Aug 17, 2022
View reviewed changes
Comment thread cincinnati/src/lib.rs Outdated
wking
wking reviewed Aug 17, 2022
View reviewed changes
Comment thread cincinnati/src/lib.rs Outdated
Copy link
Copy Markdown
Member

@wking wking Aug 17, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we leave this unpopulated, what happens?

Copy link
Copy Markdown
Contributor Author

@PratikMahajan PratikMahajan Aug 17, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

using Default:default() for Always condition

wking
wking reviewed Aug 17, 2022
View reviewed changes
Comment thread cincinnati/src/lib.rs Outdated
@PratikMahajan @wking
fix conditional edge for type always
f9db3fe 
conditional edge has an empty promql when the type of
conditional block is `Always`
This commit skips the serlialization if promql if the
promql condition is empty, which is the case for
type `Always`

Co-Authored-By: W. Trevor King <wking@tremily.us>
wking
wking approved these changes Aug 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2022
@PratikMahajan
Copy link
Copy Markdown
Contributor Author

PratikMahajan commented Aug 17, 2022

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. labels Aug 17, 2022
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 17, 2022 •
edited by openshift-ci Bot
Loading

@PratikMahajan: This pull request references [Jira Issue OCPBUGS-179](https://issues.redhat.com//browse/OCPBUGS-179), which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.0) matches configured target version for branch (4.12.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 17, 2022
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 17, 2022

/retest-required

Remaining retests: 2 against base HEAD b55a6ce and 8 for PR HEAD f9db3fe in total

@PratikMahajan
Copy link
Copy Markdown
Contributor Author

PratikMahajan commented Aug 17, 2022

/retest

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 17, 2022

/retest-required

Remaining retests: 1 against base HEAD b55a6ce and 7 for PR HEAD f9db3fe in total

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 17, 2022

/retest-required

Remaining retests: 0 against base HEAD b55a6ce and 6 for PR HEAD f9db3fe in total

@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2022
@PratikMahajan
add location flag for oc binary download
297f59c 
add `-L` to follow redirects in case the URL has changed
wking
wking approved these changes Aug 17, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@wking wking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 17, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PratikMahajan, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [PratikMahajan,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@PratikMahajan
Copy link
Copy Markdown
Contributor Author

PratikMahajan commented Aug 17, 2022

/override ci/prow/e2e

Will be fixed in #719

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 17, 2022

@PratikMahajan: Overrode contexts on behalf of PratikMahajan: ci/prow/e2e

Details

In response to this:

/override ci/prow/e2e

Will be fixed in #719

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@PratikMahajan PratikMahajan merged commit f84f5c0 into openshift:master Aug 17, 2022
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Aug 17, 2022 •
edited by openshift-ci Bot
Loading

@PratikMahajan: All pull requests linked via external trackers have merged:

[Jira Issue OCPBUGS-179](https://issues.redhat.com//browse/OCPBUGS-179) has been moved to the MODIFIED state.

Details

In response to this:

conditional edge has an empty promql when the type of
conditional block is Always
This commit skips the serlialization if promql if the
promql condition is empty, which is the case for
type Always

Co-Authored-By: W. Trevor King wking@tremily.us

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 17, 2022

@PratikMahajan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e 297f59c link unknown /test e2e

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wking wking wking approved these changes

@jottofar jottofar Awaiting requested review from jottofar

Assignees

@wking wking

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@PratikMahajan @openshift-ci-robot @wking