MCO-1644: API bump for MCN V1 API updates by isabella-janssen · Pull Request #320 · openshift/client-go

isabella-janssen · 2025-04-11T17:07:57Z

This bumps the API version to point to API commit openshift/api@9b80d67.

Steps taken:

go get github.com/openshift/api@9b80d67473bc15d85312ffda09dcde489c8e0545
go mod tidy
go mod vendor
go mod verify
make generate

openshift-ci-robot · 2025-04-11T17:08:01Z

@isabella-janssen: This pull request references MCO-1519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This bumps the API version to point to API PR openshift/api#2255.

Steps:

Replace github.com/openshift/api with github.com/isabella-janssen/openshift-api v0.0.0-20250409155250-8fcc4e71758a

go mod tidy

go mod vendor

make generate (did not update any files)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-04-11T17:08:14Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: isabella-janssen
Once this PR has been reviewed and has the lgtm label, please assign bertinatto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-04-17T18:34:25Z

@isabella-janssen: This pull request references MCO-1519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This bumps the API version to point to API PR openshift/api#2255. Once that PR has merged, this PR will need to be updated to point to the correct API commit.

Steps taken:

Replace github.com/openshift/api with github.com/isabella-janssen/openshift-api v0.0.0-20250411191959-5fafc7d5a3cb

go mod tidy

go mod vendor

make generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-04-18T16:13:02Z

@isabella-janssen: This pull request references MCO-1519 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This bumps the API version to point to API PR openshift/api#2255. Once that PR has merged, this PR will need to be updated to point to the correct API commit.

Steps taken:

Replace github.com/openshift/api with github.com/isabella-janssen/openshift-api@create-mcn-v1-api

go mod tidy

go mod vendor

make generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

bertinatto · 2025-04-22T11:14:55Z

 // retracted by itself.
 retract v0.0.1
+
+replace github.com/openshift/api => github.com/isabella-janssen/openshift-api v0.0.0-20250411191959-5fafc7d5a3cb


Leftover from WIP changes?

Yes, I'll convert this PR back into a draft for now.

openshift-ci-robot · 2025-04-22T19:10:29Z

@isabella-janssen: No Jira issue with key MCO-15189 exists in the tracker at https://issues.redhat.com/.
Once a valid jira issue is referenced in the title of this pull request, request a refresh with /jira refresh.

Details

In response to this:

This bumps the API version to point to API PR openshift/api#2255. Once that PR has merged, this PR will need to be updated to point to the correct API commit.

Steps taken:

Replace github.com/openshift/api with github.com/isabella-janssen/openshift-api@create-mcn-v1-api

go mod tidy

go mod vendor

make generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2025-04-22T19:10:38Z

@isabella-janssen: This pull request references MCO-1518 which is a valid jira issue.

Details

In response to this:

This bumps the API version to point to API PR openshift/api#2255. Once that PR has merged, this PR will need to be updated to point to the correct API commit.

Steps taken:

Replace github.com/openshift/api with github.com/isabella-janssen/openshift-api@create-mcn-v1-api

go mod tidy

go mod vendor

make generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-04-22T21:01:43Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/fac1e850-1fbc-11f0-862d-e84003de272e-0

openshift-ci · 2025-04-23T00:37:52Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2cdb3df0-1fdb-11f0-8ce0-4789540d94c0-0

openshift-ci · 2025-04-23T00:38:41Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/4b3356c0-1fdb-11f0-9b35-226304d0edb2-0

openshift-ci · 2025-04-23T00:39:04Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/5783a6f0-1fdb-11f0-90db-891d487db3b1-0

openshift-ci · 2025-04-23T00:44:15Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/10678010-1fdc-11f0-8580-ddd5fb8ff9ed-0

openshift-ci · 2025-04-23T00:45:14Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-ovn-serial-ipv4

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/320af350-1fdc-11f0-8aee-f8ae028cc17c-0

openshift-ci · 2025-04-23T00:46:20Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2025-04-23T00:47:06Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2025-04-23T00:47:50Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-metal-ipi-serial-ovn-dualstack

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/915b95d0-1fdc-11f0-9fe0-b77ca0a6c4db-0

openshift-ci · 2025-04-23T11:51:49Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/518ee7b0-2039-11f0-9293-096f11f7234d-0

openshift-ci · 2025-04-23T11:52:17Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-azure-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/6426bb50-2039-11f0-8ebb-448e5b2e76d2-0

openshift-ci · 2025-04-23T11:53:39Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7f56b920-2039-11f0-8c1b-32964ce9e1e2-0

openshift-ci · 2025-04-23T11:54:13Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-nightly-4.19-e2e-vsphere-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/9f8c1d70-2039-11f0-9397-897d6e7a216b-0

openshift-ci · 2025-04-23T11:55:28Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/d55d1f80-2039-11f0-8579-2e6b98bca7b9-0

openshift-ci · 2025-04-23T11:58:05Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2025-04-23T11:58:35Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2025-04-23T11:58:54Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 0 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

openshift-ci · 2025-04-23T18:31:48Z

@isabella-janssen: This PR was included in a payload test run from openshift/origin#29701
trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

periodic-ci-openshift-release-master-ci-4.19-e2e-aws-ovn-techpreview-serial

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/3424ddf0-2071-11f0-8bbf-22c14e462e13-0

openshift-ci-robot · 2025-04-23T20:59:16Z

@isabella-janssen: This pull request references MCO-1644 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This bumps the API version to point to API PR openshift/api#2255. Once that PR has merged, this PR will need to be updated to point to the correct API commit.

Steps taken:

Replace github.com/openshift/api with github.com/isabella-janssen/openshift-api@create-mcn-v1-api

go mod tidy

go mod vendor

make generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

isabella-janssen · 2025-04-25T16:11:53Z

/test all

openshift-ci-robot · 2025-04-25T16:42:19Z

@isabella-janssen: This pull request references MCO-1644 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

Details

In response to this:

This bumps the API version to point to API commit openshift/api@9b80d67.

Steps taken:

go get github.com/openshift/api@9b80d67473bc15d85312ffda09dcde489c8e0545

go mod tidy

go mod vendor

go mod verify

make generate

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-04-25T16:54:56Z

@isabella-janssen: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 11, 2025

isabella-janssen marked this pull request as draft April 11, 2025 17:08

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2025

openshift-ci Bot requested review from JoelSpeed and bertinatto April 11, 2025 17:08

isabella-janssen force-pushed the mco-1519 branch 2 times, most recently from 6273472 to 4164208 Compare April 18, 2025 15:39

isabella-janssen marked this pull request as ready for review April 18, 2025 15:41

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 18, 2025

openshift-ci Bot requested a review from deads2k April 18, 2025 15:41

bertinatto reviewed Apr 22, 2025

View reviewed changes

isabella-janssen changed the title ~~MCO-1519: API bump for MCN V1 API updates~~ MCO-15189: API bump for MCN V1 API updates Apr 22, 2025

openshift-ci-robot removed the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 22, 2025

isabella-janssen changed the title ~~MCO-15189: API bump for MCN V1 API updates~~ MCO-1518: API bump for MCN V1 API updates Apr 22, 2025

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 22, 2025

isabella-janssen marked this pull request as draft April 22, 2025 19:11

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2025

This was referenced Apr 22, 2025

MCO-1519: Adapt MCN tests to use V1 API openshift/origin#29701

Merged

MCO-1518: API & client-go bumps for MCN V1 API openshift/origin#29702

Closed

isabella-janssen force-pushed the mco-1519 branch from 4164208 to b84d4e8 Compare April 23, 2025 16:57

isabella-janssen changed the title ~~MCO-1518: API bump for MCN V1 API updates~~ MCO-1644: API bump for MCN V1 API updates Apr 23, 2025

isabella-janssen added 3 commits April 25, 2025 12:37

update api dependency to commit 9b80d67

920f80b

bump(api): go mod vendor

20c76b5

bump(api): make generate

fbfc15a

isabella-janssen force-pushed the mco-1519 branch from b84d4e8 to fbfc15a Compare April 25, 2025 16:40

isabella-janssen marked this pull request as ready for review April 25, 2025 16:41

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 25, 2025

openshift-ci Bot requested a review from bertinatto April 25, 2025 16:42

sdodson merged commit 5f55ff6 into openshift:master Apr 25, 2025
2 of 3 checks passed

isabella-janssen deleted the mco-1519 branch May 15, 2025 03:04

Conversation

isabella-janssen commented Apr 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 11, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Apr 11, 2025

Uh oh!

openshift-ci-robot commented Apr 17, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Apr 18, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bertinatto Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

isabella-janssen Apr 22, 2025

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Apr 22, 2025

Uh oh!

openshift-ci-robot commented Apr 22, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Apr 22, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci Bot commented Apr 23, 2025

Uh oh!

openshift-ci-robot commented Apr 23, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

isabella-janssen commented Apr 25, 2025

Uh oh!

openshift-ci-robot commented Apr 25, 2025 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Apr 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

isabella-janssen commented Apr 11, 2025 •

edited

Loading

openshift-ci-robot commented Apr 11, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Apr 17, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Apr 18, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Apr 22, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Apr 23, 2025 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Apr 25, 2025 •

edited by openshift-ci Bot

Loading