manifests: reorganize to match infra operator convention#186
Closed
sjenning wants to merge 1 commit into
Closed
Conversation
sjenning
force-pushed
the
rework-manifests
branch
from
17a0a88 to
7006d52
Compare
Contributor
Author
|
gah, forgot to update the |
sjenning
force-pushed
the
rework-manifests
branch
from
7006d52 to
079cf4c
Compare
Contributor
Author
|
ok, turns out the |
sjenning
force-pushed
the
rework-manifests
branch
from
079cf4c to
86ae6ed
Compare
Contributor
Author
|
/retest |
Contributor
Author
|
/test e2e-aws |
Contributor
|
/lgtm |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Contributor
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Contributor
Author
|
master is frozen but this is approved. will carry this commit in the base of ongoing PRs. next is #185 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of this is a noop. Just reorganizing to look like other operators. Currently a ton of resources are just crammed into the
05_deployment.yamlfile.Examples:
https://github.com/openshift/cluster-ingress-operator/tree/master/manifests
https://github.com/openshift/console-operator/tree/master/manifests
The three actual changes are
defaultSA with its bindings. New installs won't have this.Removal of(manifests: reorganize to match infra operator convention #186 (comment))control-plane: controller-managerandcontroller-tools.k8s.io: "1.0"labels@dgoodwin @joelddiaz @derekwaynecarr