Bug 1896919: [release-4.6] add new credentials field for AWS Secrets by openshift-cherrypick-robot · Pull Request #268 · openshift/cloud-credential-operator

openshift-cherrypick-robot · 2020-11-11T14:25:36Z

This is an automated cherry-pick of #264

/assign joelddiaz

Start storing a usable AWS credentials config file in the 'credentials' field of the Secret. This should allow a consumer of the credentials to just point to the config stored in that field when setting up an AWS client. Also make sure we are re-queueing CredentialsRequest objects every 1hr10min (so that we are at least periodically doing a full reconcile to reestore any lost credentials).

joelddiaz · 2020-11-11T20:40:26Z

closing. let the bot cherry pick after the parent PR has a BZ assigned
/close

openshift-ci-robot · 2020-11-11T20:40:43Z

@joelddiaz: Closed this PR.

Details

In response to this:

closing. let the bot cherry pick after the parent PR has a BZ assigned
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson · 2020-11-11T20:46:10Z

/reopen

openshift-ci-robot · 2020-11-11T20:46:27Z

@sdodson: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-11-11T20:46:28Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.6] add new credentials field for AWS Secrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

joelddiaz · 2020-11-11T20:48:13Z

/retitle Bug 1896919: [release-4.6] add new credentials field for AWS Secrets

openshift-ci-robot · 2020-11-11T20:48:33Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1896919, which is invalid:

expected the bug to target the "4.6.z" release, but it targets "---" instead
expected dependent Bugzilla bug 1896918 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
expected dependent Bugzilla bug 1896918 to target a release in 4.7.0, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1896919: [release-4.6] add new credentials field for AWS Secrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

joelddiaz · 2020-11-13T20:46:27Z

/lgtm

openshift-bot · 2020-11-13T21:55:37Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-13T23:39:33Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-14T01:00:35Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-14T01:00:38Z

@openshift-bot: This pull request references Bugzilla bug 1896919, which is invalid:

expected the bug to target the "4.6.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-14T02:28:31Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-11-15T01:01:13Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-15T01:01:16Z

@openshift-bot: This pull request references Bugzilla bug 1896919, which is invalid:

expected the bug to target the "4.6.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-11-16T01:01:13Z

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

openshift-ci-robot · 2020-11-16T01:01:16Z

@openshift-bot: This pull request references Bugzilla bug 1896919, which is invalid:

expected the bug to target the "4.6.z" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Recalculating validity in case the underlying Bugzilla bug has changed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

sdodson · 2020-11-16T01:50:20Z

/bugzilla refresh

openshift-ci-robot · 2020-11-16T01:50:27Z

@sdodson: This pull request references Bugzilla bug 1896919, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1896918 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1896918 targets the "4.7.0" release, which is one of the valid target releases: 4.7.0
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

lwan-wanglin · 2021-01-25T10:01:20Z

/lgtm
/label qe-approved
Verified with the open pr(4.6.0-0.ci.test-2021-01-25-090310-ci-ln-g33mgck)
cco adds credentials field in secret related by CredentialsRequest.

openshift-ci-robot · 2021-01-25T10:01:21Z

@lwan-wanglin: The label(s) qe-approved cannot be applied, because the repository doesn't have them

Details

In response to this:

/lgtm
/label qe-approved
Verified with the open pr(4.6.0-0.ci.test-2021-01-25-090310-ci-ln-g33mgck)
cco adds credentials field in secret related by CredentialsRequest.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-01-25T10:01:45Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelddiaz, lwan-wanglin, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [joelddiaz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

staebler · 2021-01-25T16:18:06Z

/uncc

openshift-ci-robot · 2021-01-27T21:06:33Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

openshift/cloud-credential-operator#268

Bugzilla bug 1896919 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1896919: [release-4.6] add new credentials field for AWS Secrets

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot mentioned this pull request Nov 11, 2020

Bug 1896918: add new credentials field for AWS Secrets #264

Merged

openshift-ci-robot assigned joelddiaz Nov 11, 2020

openshift-ci-robot requested review from joelddiaz and staebler November 11, 2020 14:26

openshift-ci-robot closed this Nov 11, 2020

openshift-ci-robot reopened this Nov 11, 2020

openshift-ci-robot changed the title ~~[release-4.6] add new credentials field for AWS Secrets~~ Bug 1896919: [release-4.6] add new credentials field for AWS Secrets Nov 11, 2020

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Nov 11, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 11, 2020

openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 13, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 16, 2020

joelddiaz mentioned this pull request Nov 19, 2020

assets/controller.yaml: support using aws config for credentials openshift/aws-ebs-csi-driver-operator#99

Merged

openshift-ci-robot assigned lwan-wanglin Jan 25, 2021

openshift-ci-robot removed the request for review from staebler January 25, 2021 16:18

jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Jan 27, 2021

openshift-merge-robot merged commit f894398 into openshift:release-4.6 Jan 27, 2021

Conversation

openshift-cherrypick-robot commented Nov 11, 2020

Uh oh!

joelddiaz commented Nov 11, 2020

Uh oh!

openshift-ci-robot commented Nov 11, 2020

Uh oh!

sdodson commented Nov 11, 2020

Uh oh!

openshift-ci-robot commented Nov 11, 2020

Uh oh!

openshift-ci-robot commented Nov 11, 2020

Uh oh!

joelddiaz commented Nov 11, 2020

Uh oh!

openshift-ci-robot commented Nov 11, 2020

Uh oh!

joelddiaz commented Nov 13, 2020

Uh oh!

openshift-bot commented Nov 13, 2020

Uh oh!

openshift-bot commented Nov 13, 2020

Uh oh!

openshift-bot commented Nov 14, 2020

Uh oh!

openshift-ci-robot commented Nov 14, 2020

Uh oh!

openshift-bot commented Nov 14, 2020

Uh oh!

openshift-bot commented Nov 15, 2020

Uh oh!

openshift-ci-robot commented Nov 15, 2020

Uh oh!

openshift-bot commented Nov 16, 2020

Uh oh!

openshift-ci-robot commented Nov 16, 2020

Uh oh!

sdodson commented Nov 16, 2020

Uh oh!

openshift-ci-robot commented Nov 16, 2020

Uh oh!

lwan-wanglin commented Jan 25, 2021

Uh oh!

openshift-ci-robot commented Jan 25, 2021

Uh oh!

openshift-ci-robot commented Jan 25, 2021

Uh oh!

staebler commented Jan 25, 2021

Uh oh!

openshift-ci-robot commented Jan 27, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants