Skip to content

Rename ibmcloud command to create-shared-secrets#360

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
BobbyRadford:rename-ibm-command
Jul 2, 2021
Merged

Rename ibmcloud command to create-shared-secrets#360
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
BobbyRadford:rename-ibm-command

Conversation

@BobbyRadford
Copy link
Copy Markdown
Contributor

@BobbyRadford BobbyRadford commented Jun 30, 2021 •
edited
Loading

Related to this PR: #356

Addresses @joelddiaz 's comment: #356 (comment)

@openshift-ci openshift-ci Bot requested review from abutcher and joelddiaz June 30, 2021 15:12
joelddiaz
joelddiaz reviewed Jun 30, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 30, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 30, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BobbyRadford, joelddiaz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 30, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 30, 2021 •
edited
Loading

Codecov Report

Merging #360 (8d155b8) into master (a23cab3) will not change coverage.
The diff coverage is 20.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #360   +/-   ##
=======================================
  Coverage   44.82%   44.82%           
=======================================
  Files          74       74           
  Lines        6918     6918           
=======================================
  Hits         3101     3101           
  Misses       3329     3329           
  Partials      488      488
Impacted Files Coverage Δ
pkg/cmd/provisioning/ibmcloud/ibmcloud.go 0.00% <0.00%> (ø)
...cmd/provisioning/ibmcloud/create_shared_secrets.go 38.57% <25.00%> (ø)

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 30, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

20 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 30, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jun 30, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 1, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Copy Markdown
Contributor

openshift-bot commented Jul 2, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit f82e277 into openshift:master Jul 2, 2021
ming1013 pushed a commit to ming1013/cloud-credential-operator that referenced this pull request Dec 15, 2025
@openshift-merge-robot
Merge pull request openshift#360 from BobbyRadford/rename-ibm-command
4ff2f5c 
Rename ibmcloud command to create-shared-secrets
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@abutcher abutcher Awaiting requested review from abutcher

1 more reviewer

@joelddiaz joelddiaz joelddiaz left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@joelddiaz joelddiaz

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BobbyRadford @openshift-bot @joelddiaz @openshift-merge-robot