Skip to content

Add doc for ibmcloud#422

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
mkumatag:ibmcloud-doc
Dec 2, 2021
Merged

Add doc for ibmcloud#422
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
mkumatag:ibmcloud-doc

Conversation

@mkumatag
Copy link
Copy Markdown
Member

PR for IBMCloud documentation

xref: https://issues.redhat.com/browse/MULTIARCH-1938

@mkumatag
Copy link
Copy Markdown
Member Author

/cc @joelddiaz @akhil-rane

Copy link
Copy Markdown
Contributor

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@joelddiaz
Copy link
Copy Markdown
Contributor

/assign @jeana-redhat @lwan-wanglin @sferich888
I expect this is the last PR related to enabling IBMCloud support in this repo. No functionaly changes here, just documenting what has been done and how to use it.

@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 18, 2021
Comment thread docs/ccoctl.md
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2021
Copy link
Copy Markdown
Contributor

@joelddiaz joelddiaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 19, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 19, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: joelddiaz, mkumatag

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown

@jeana-redhat jeana-redhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just left a question that will be relevant for user docs. If you want to add that to this, I can hold off on the docs label - lmk

Comment thread docs/ccoctl.md
@lwan-wanglin
Copy link
Copy Markdown

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Nov 22, 2021
@mkumatag
Copy link
Copy Markdown
Member Author

mkumatag commented Dec 1, 2021

@jeana-redhat @sferich888 ping

@jeana-redhat
Copy link
Copy Markdown

Thanks for the ping! I was out last week and missed the earlier comment :)

/label docs-approved

@openshift-ci openshift-ci Bot added the docs-approved Signifies that Docs has signed off on this PR label Dec 1, 2021
@sferich888
Copy link
Copy Markdown

/label px-approved

@openshift-ci openshift-ci Bot added the px-approved Signifies that Product Support has signed off on this PR label Dec 2, 2021
@openshift-merge-robot openshift-merge-robot merged commit b3496af into openshift:master Dec 2, 2021
ming1013 pushed a commit to ming1013/cloud-credential-operator that referenced this pull request Dec 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants