Skip to content

[release-4.14] Ocpbugs 25275: Azure Workload Identity for layered OLM Operators#641

Closed
gallettilance wants to merge 1 commit intoopenshift:release-4.14from
gallettilance:ocpbugs-25275
Closed

[release-4.14] Ocpbugs 25275: Azure Workload Identity for layered OLM Operators#641
gallettilance wants to merge 1 commit intoopenshift:release-4.14from
gallettilance:ocpbugs-25275

Conversation

@gallettilance
Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci openshift-ci Bot requested review from dlom and jstuever December 14, 2023 19:07
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 14, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gallettilance
Once this PR has been reviewed and has the lgtm label, please assign 2uasimojo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gallettilance gallettilance changed the title Ocpbugs 25275: Azure Workload Identity for layered OLM Operators [release-4.14] Ocpbugs 25275: Azure Workload Identity for layered OLM Operators Dec 14, 2023
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 14, 2023

Codecov Report

Merging #641 (d120839) into release-4.14 (549cff9) will increase coverage by 0.07%.
Report is 2 commits behind head on release-4.14.
The diff coverage is 68.75%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release-4.14     #641      +/-   ##
================================================
+ Coverage         47.89%   47.96%   +0.07%     
================================================
  Files                96       96              
  Lines             11679    11737      +58     
================================================
+ Hits               5594     5630      +36     
- Misses             5465     5483      +18     
- Partials            620      624       +4     
Files Coverage Δ
...redentialsrequest/credentialsrequest_controller.go 48.78% <0.00%> (ø)
pkg/azure/actuator.go 60.97% <69.62%> (+7.27%) ⬆️

... and 2 files with indirect coverage changes

@jstuever
Copy link
Copy Markdown
Contributor

Is there a reason this wasn't backported using /cherry-pick release-4.14 from #587?

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 14, 2023

@gallettilance: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security d120839 link false /test security
ci/prow/e2e-aws-ovn d120839 link true /test e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gallettilance
Copy link
Copy Markdown
Contributor Author

@jstuever because i didn't know of the existence of that command. Closing in favor of #643

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants