Bug 1996783: Bump to Go v1.16 and OCP v4.9 by pierreprinetti · Pull Request #73 · openshift/cloud-provider-openstack

pierreprinetti · 2021-08-23T15:44:17Z

No description provided.

openshift-ci · 2021-08-23T16:23:04Z

@pierreprinetti: This pull request references Bugzilla bug 1996783, which is invalid:

expected the bug to target the "4.9.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1996783: Bump to Go v1.16 and OCP v4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2021-08-23T16:25:43Z

/bugzilla refresh

openshift-ci · 2021-08-23T16:27:54Z

@pierreprinetti: An error was encountered querying GitHub for users with public email (juriarte@redhat.com) for bug 1996783 on the Bugzilla server at https://bugzilla.redhat.com. No known errors were detected, please see the full error message for details.

Full error message.


non-200 OK status code: 403 Forbidden body: "{\n  \"documentation_url\": \"https://docs.github.com/en/free-pro-team@latest/rest/overview/resources-in-the-rest-api#secondary-rate-limits\",\n  \"message\": \"You have exceeded a secondary rate limit. Please wait a few minutes before you try again.\"\n}\n"

Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2021-08-23T19:00:21Z

/bugzilla refresh

pierreprinetti · 2021-08-23T19:01:20Z

/retest

openshift-ci · 2021-08-23T19:04:29Z

@pierreprinetti: This pull request references Bugzilla bug 1996783, which is valid.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.9.0) matches configured target release for branch (4.9.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @eurijon

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2021-08-24T08:50:23Z

/hold

pierreprinetti · 2021-08-24T08:59:51Z

/hold cancel

pierreprinetti · 2021-08-24T09:04:25Z

This is now ready for review.
/cc mandre mdbooth

mandre · 2021-08-24T09:58:20Z

@@ -1,10 +0,0 @@
-FROM openshift/origin-release:golang-1.10


Interestingly, the images/manila-provisioner/Dockerfile.openshift.ci image is referenced in the release repo for older branches.

❯ ag "images/manila-provisioner/Dockerfile.openshift.ci" ci-operator/config/openshift-priv/cloud-provider-openstack/openshift-priv-cloud-provider-openstack-release-4.4.yaml 13:- dockerfile_path: images/manila-provisioner/Dockerfile.openshift.ci ci-operator/config/openshift-priv/cloud-provider-openstack/openshift-priv-cloud-provider-openstack-release-4.3.yaml 13:- dockerfile_path: images/manila-provisioner/Dockerfile.openshift.ci ci-operator/config/openshift-priv/cloud-provider-openstack/openshift-priv-cloud-provider-openstack-release-4.1.yaml 13:- dockerfile_path: images/manila-provisioner/Dockerfile.openshift.ci ci-operator/config/openshift-priv/cloud-provider-openstack/openshift-priv-cloud-provider-openstack-release-4.2.yaml 13:- dockerfile_path: images/manila-provisioner/Dockerfile.openshift.ci ci-operator/config/openshift/cloud-provider-openstack/openshift-cloud-provider-openstack-release-4.3.yaml 13:- dockerfile_path: images/manila-provisioner/Dockerfile.openshift.ci ci-operator/config/openshift/cloud-provider-openstack/openshift-cloud-provider-openstack-release-4.4.yaml 13:- dockerfile_path: images/manila-provisioner/Dockerfile.openshift.ci ci-operator/config/openshift/cloud-provider-openstack/openshift-cloud-provider-openstack-release-4.1.yaml 13:- dockerfile_path: images/manila-provisioner/Dockerfile.openshift.ci ci-operator/config/openshift/cloud-provider-openstack/openshift-cloud-provider-openstack-release-4.2.yaml 13:- dockerfile_path: images/manila-provisioner/Dockerfile.openshift.ci

mandre · 2021-08-24T10:03:01Z

@@ -1,9 +1,9 @@
-FROM openshift/origin-release:golang-1.10


This image is apparently never used and can potentially be removed:

❯ ag --stats "images/manila-provisioner/Dockerfile\s" 0 matches

Use the same pattern across all Dockerfiles and remove duplicates. Also remove the dockerfile for the deprecated Manila provisioner, for which the image is not used any more in 4.9.

pierreprinetti · 2021-08-24T10:48:36Z

Good catch; I am removing the image for the deprecated Manila provisioner.

pierreprinetti · 2021-08-24T11:47:16Z

/test e2e-openstack-csi-manila

EmilienM · 2021-08-24T12:03:02Z

/lgtm
/hold

Feel free to unhold when CI is happier.
Note that the Cinder job will fail on 4 tests, related to Snapshot. Manila will fail on one test, but the rest should work. We're working on this into separated PRs.

openshift-ci · 2021-08-24T12:05:29Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, pierreprinetti

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [EmilienM,pierreprinetti]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

EmilienM · 2021-08-24T12:10:35Z

The errors on e2e-openstack-csi-cinder are known, feel free to ignore them.

pierreprinetti · 2021-08-24T12:22:57Z

/hold cancel

Thanks Emilien, canceling the hold following your precious advice.

openshift-bot · 2021-08-24T12:31:10Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-24T12:40:15Z

@pierreprinetti: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-openstack-csi-cinder	`e029ed4`	link	`/test e2e-openstack-csi-cinder`
ci/prow/e2e-openstack-csi-manila	`e029ed4`	link	`/test e2e-openstack-csi-manila`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-08-24T12:43:10Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-24T12:55:11Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2021-08-24T13:19:10Z

/retest-required

Please review the full test history for this PR and help us cut down flakes.

openshift-ci · 2021-08-24T14:48:04Z

@pierreprinetti: All pull requests linked via external trackers have merged:

openshift/cloud-provider-openstack#73

Bugzilla bug 1996783 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1996783: Bump to Go v1.16 and OCP v4.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Harmonise Go to v1.16 and OCP to v4.9

1c87cc9

pierreprinetti changed the title ~~Harmonise Go and OCP versions and remove CI-specific images~~ Bug 1996783: Bump to Go v1.16 and OCP v4.9 Aug 23, 2021

openshift-ci Bot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Aug 23, 2021

openshift-ci Bot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 23, 2021

openshift-ci Bot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Aug 23, 2021

openshift-ci Bot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Aug 23, 2021

openshift-ci Bot requested a review from eurijon August 23, 2021 19:04

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2021

openshift-ci Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Aug 24, 2021

pierreprinetti force-pushed the bump_images branch from cd30ab5 to d768afe Compare August 24, 2021 09:01

openshift-ci Bot requested review from mandre and mdbooth August 24, 2021 09:04

mandre reviewed Aug 24, 2021

View reviewed changes

pierreprinetti force-pushed the bump_images branch 2 times, most recently from 1a55308 to 835326e Compare August 24, 2021 10:45

Remove unused Dockerfiles

e029ed4

Use the same pattern across all Dockerfiles and remove duplicates. Also remove the dockerfile for the deprecated Manila provisioner, for which the image is not used any more in 4.9.

pierreprinetti force-pushed the bump_images branch from 835326e to e029ed4 Compare August 24, 2021 10:47

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2021

openshift-ci Bot assigned EmilienM Aug 24, 2021

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2021

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 24, 2021

openshift-merge-robot merged commit 7194ed1 into openshift:master Aug 24, 2021

pierreprinetti deleted the bump_images branch August 24, 2021 19:00

pierreprinetti mentioned this pull request Aug 25, 2021

Bug 1996783: Bump Go to v1.16 - fixup #74

Merged

Conversation

pierreprinetti commented Aug 23, 2021

Uh oh!

openshift-ci Bot commented Aug 23, 2021

Uh oh!

pierreprinetti commented Aug 23, 2021

Uh oh!

openshift-ci Bot commented Aug 23, 2021

Uh oh!

pierreprinetti commented Aug 23, 2021

Uh oh!

pierreprinetti commented Aug 23, 2021

Uh oh!

openshift-ci Bot commented Aug 23, 2021

Uh oh!

pierreprinetti commented Aug 24, 2021

Uh oh!

pierreprinetti commented Aug 24, 2021

Uh oh!

pierreprinetti commented Aug 24, 2021

Uh oh!

mandre Aug 24, 2021

Choose a reason for hiding this comment

Uh oh!

mandre Aug 24, 2021

Choose a reason for hiding this comment

Uh oh!

pierreprinetti commented Aug 24, 2021

Uh oh!

pierreprinetti commented Aug 24, 2021

Uh oh!

EmilienM commented Aug 24, 2021

Uh oh!

openshift-ci Bot commented Aug 24, 2021

Uh oh!

EmilienM commented Aug 24, 2021

Uh oh!

pierreprinetti commented Aug 24, 2021

Uh oh!

openshift-bot commented Aug 24, 2021

Uh oh!

openshift-ci Bot commented Aug 24, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-bot commented Aug 24, 2021

Uh oh!

openshift-bot commented Aug 24, 2021

Uh oh!

openshift-bot commented Aug 24, 2021

Uh oh!

openshift-ci Bot commented Aug 24, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

openshift-ci Bot commented Aug 24, 2021 •

edited

Loading