Implement leader election for manager#201
Implement leader election for manager#201openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
There was a problem hiding this comment.
Can you add some context from openshift/machine-api-operator#571 to the commit log?
Using leader election will add stronger guarantees than we have today that only one controller is running at a time to protect against edge cases where the deployment replica could be increased or upgrades with permissive maxSurge.
Always welcome to have more context in a commit log :)
/lgtm
This adds integration with: openshift/machine-api-operator#571 Adding 3 new cli arguments for configuring leader elections: -leader-elect -leader-elect-lease-duration int -leader-elect-resource-namespace string Using leader election will add stronger guarantees than we have today that only one controller is running at a time to protect against edge cases where the deployment replica could be increased or upgrades with permissive maxSurge.
|
Thanks! I've added some more context based on the PRs that went into the other api-providers. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
Bad news is that I have no idea what's going on with CI :( |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Thanks @cfergeau - may have been luck that it passed but glad it's in! |
5 participants
This adds integration with:
openshift/machine-api-operator#571