Update k8s/vendoring/...#249
Conversation
The libvirt-actuator binary was removed in ff2852b but not removed from Makefile
It's no longer needed since c190886
Update go version to 1.17 and run go mod tidy && go mod vendor
We won't need to update it as often.
The gendeepcopy rule assumes the GOPATH env var is set when it builds deepcopy-gen. When this is set, this changes the behaviour of deepcopy-gen and instructs it to put the files it generates in $GOPATH, which is not what we want. This commit uses $(go env GOPATH) instead of $$GOPATH to solve this issue.
This adjusts cluster-api-provider to the changes from openshift/machine-api-operator#943
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@cfergeau: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
#251 is taking all those patches and add another commit to disable actuator unit tests. |
3 participants
This updates cluster-api-provider-libvirt to use more recent dependencies, and should help with build problems some people have been hitting such as openshift/installer#6812
make testdoes not pass after these changes, I did not have time to investigate why. This PR should help us get more extensive testing through CI to see exactly how much is non-working.