CNF-23050: Migrate away from deprecated ioutil

[sebrandon1]

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

Migration from deprecated ioutil functions:

• Replaced ioutil.TempDir with os.MkdirTemp and ioutil.WriteFile with os.WriteFile in the createFiles method of cloudinit.go to create temporary directories and write files. [1] [2]
• Replaced ioutil.TempFile with os.CreateTemp in the createFile method of ignition.go for creating temporary files. [1] [2]

Summary by CodeRabbit

• Chores
  • Updated internal dependencies to remove deprecated libraries and improve code maintainability.

[openshift-ci]

@sebrandon1: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/unit	71d88cc	link	true	/test unit
ci/prow/verify-deps	71d88cc	link	true	/test verify-deps
ci/prow/govet	71d88cc	link	true	/test govet

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[cfergeau]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [cfergeau]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 25f71870-da23-4dac-9507-36219d3072aa

📥 Commits

Reviewing files that changed from the base of the PR and between 63c1b63 and d5bd248.

📒 Files selected for processing (2)

• pkg/cloud/libvirt/client/cloudinit.go
• pkg/cloud/libvirt/client/ignition.go

---

Walkthrough

Two files in the libvirt cloud client are updated to replace deprecated io/ioutil functions with their os package equivalents: os.MkdirTemp, os.WriteFile, and os.CreateTemp.

Changes

Cohort / File(s)	Summary
Deprecated io/ioutil Cleanup pkg/cloud/libvirt/client/cloudinit.go, pkg/cloud/libvirt/client/ignition.go	Replaces deprecated io/ioutil usage with modern os package functions: os.MkdirTemp for temporary directory creation, os.WriteFile for file writes, and os.CreateTemp for temporary file creation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 12

✅ Passed checks (12 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and specifically summarizes the main change: migrating away from deprecated ioutil functions to their os package equivalents.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR modifies only non-test source files to migrate from deprecated io/ioutil functions. Repository uses standard Go testing, not Ginkgo. No Ginkgo tests are introduced or modified.
Test Structure And Quality	✅ Passed	This PR contains only production code changes (cloudinit.go and ignition.go) migrating from deprecated io/ioutil functions. No Ginkgo test files or test code are included.
Microshift Test Compatibility	✅ Passed	This PR only refactors library code to migrate from deprecated io/ioutil functions to modern os package equivalents. No new Ginkgo e2e tests are added, so the check does not apply.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PR only modifies non-test utility files (cloudinit.go and ignition.go) migrating from deprecated io/ioutil to os package. No new Ginkgo e2e tests added; check not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR modifies only internal Go utility files (cloudinit.go, ignition.go) to replace deprecated io/ioutil functions with os package equivalents. No deployment manifests, operator code, or controllers are added or modified.
Ote Binary Stdout Contract	✅ Passed	PR replaces deprecated io/ioutil functions with os equivalents; no new stdout writes introduced, OTE Binary Stdout Contract maintained.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	This PR modifies library files in the cloud provider client and does not add any Ginkgo e2e tests.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Review rate limit: 0/10 reviews remaining, refill in 56 minutes and 33 seconds.}

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci-robot]

@sebrandon1: This pull request references CNF-23050 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

ioutil has been deprecated since Go 1.16: https://go.dev/doc/go1.16#ioutil

Tracking issue: redhat-best-practices-for-k8s/telco-bot#52

Migration from deprecated ioutil functions:

• Replaced ioutil.TempDir with os.MkdirTemp and ioutil.WriteFile with os.WriteFile in the createFiles method of cloudinit.go to create temporary directories and write files. [1] [2]
• Replaced ioutil.TempFile with os.CreateTemp in the createFile method of ignition.go for creating temporary files. [1] [2]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

New changes are detected. LGTM label has been removed.