BUG 1858400: [Performance] Increase leader elect retry period to 90s#116
BUG 1858400: [Performance] Increase leader elect retry period to 90s#116elmiko wants to merge 1 commit intoopenshift:masterfrom
Conversation
This change increases the leader election retry period to 90s. This change is being made to reduce the number of updates that can occur to etcd in a worst case leader election scenario.
openshift-ci-robot
added
bugzilla/severity-high
|
@elmiko: This pull request references Bugzilla bug 1858400, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@elmiko: This pull request references Bugzilla bug 1858400, which is valid. 3 validation(s) were run on this bug
DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@michaelgugino: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: elmiko, michaelgugino The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@michaelgugino @elmiko Just wanted to mention - openshift/cluster-api-provider-baremetal#100 (comment) |
that's a good point Danil, i'm going to put a hold on this until we figure out the proper value |
openshift-ci-robot
added
the
do-not-merge/hold
|
@elmiko: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
we discussed this as a group and we are in agreement that the 20s retry period is fine for now. i am closing this pr |
|
@elmiko: This pull request references Bugzilla bug 1858400. The bug has been updated to no longer refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
4 participants
What this PR does / why we need it:
This change increases the leader election retry period to 90s. This
change is being made to reduce the number of updates that can occur to
etcd in a worst case leader election scenario.
This was supposed to be part of #114 , but got missed due to a copy-paste error.
Which issue(s) this PR fixes
Bugzilla 1858400