Skip to content

BUG 1875598: Ensure the Virtual Machine provider state is set to Unknown when Failed#128

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
JoelSpeed:mao-update-b7d860f8
Sep 29, 2020
Merged

BUG 1875598: Ensure the Virtual Machine provider state is set to Unknown when Failed#128
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
JoelSpeed:mao-update-b7d860f8

Conversation

@JoelSpeed
Copy link
Copy Markdown

@JoelSpeed JoelSpeed commented Sep 28, 2020 •
edited
Loading

Revendor to include the bug fix from openshift/machine-api-operator#696

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Sep 28, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 28, 2020

@JoelSpeed: This pull request references Bugzilla bug 1875598, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

BUG 1875598: Ensure the Virtual Machine provider state is set to Unknown when Failed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 28, 2020

@JoelSpeed: This pull request references Bugzilla bug 1875598, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.6.0) matches configured target release for branch (4.6.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
Details

In response to this:

BUG 1875598: Ensure the Virtual Machine provider state is set to Unknown when Failed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

michaelgugino
michaelgugino approved these changes Sep 28, 2020
View reviewed changes
Copy link
Copy Markdown

@michaelgugino michaelgugino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 28, 2020

@michaelgugino: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre
Copy link
Copy Markdown
Member

mandre commented Sep 29, 2020

/test e2e-openstack

mandre
mandre reviewed Sep 29, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/hold until the tests pass

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2020
@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 29, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 29, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 29, 2020
@openshift-ci-robot openshift-ci-robot mentioned this pull request Sep 29, 2020
Merged
@JoelSpeed
Copy link
Copy Markdown
Author

JoelSpeed commented Sep 29, 2020

All tests have passed, clearing the hold

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 29, 2020
@openshift-merge-robot openshift-merge-robot merged commit b789393 into openshift:master Sep 29, 2020
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 29, 2020

@JoelSpeed: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Bugzilla bug in order for it to move to the next state.

Bugzilla bug 1875598 has not been moved to the MODIFIED state.

Details

In response to this:

BUG 1875598: Ensure the Virtual Machine provider state is set to Unknown when Failed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@JoelSpeed JoelSpeed deleted the mao-update-b7d860f8 branch September 29, 2020 09:06
This was referenced Sep 29, 2020
Merged
Merged
@EmilienM EmilienM mentioned this pull request Jan 31, 2023
Closed
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@iamemilio @pierreprinetti
Fixes some minor bugs and unclear syntax (openshift#128)
b14cf44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre left review comments

@adduarte adduarte Awaiting requested review from adduarte

+1 more reviewer

@michaelgugino michaelgugino michaelgugino approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-low Referenced Bugzilla bug's severity is low for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JoelSpeed @openshift-ci-robot @mandre @michaelgugino @openshift-merge-robot