Bug 1908466: check if compute AZ is available by EmilienM · Pull Request #143 · openshift/cluster-api-provider-openstack

EmilienM · 2020-12-10T21:56:52Z

Before creating a machine in a given AZ, it'll check that the AZ
actually exists and is available.

JIRA: https://issues.redhat.com/browse/OSASINFRA-1848
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1908466
Signed-off-by: Emilien Macchi emilien@redhat.com

EmilienM · 2020-12-10T22:01:12Z

/label platform/openstack
/assign EmilienM
/cc pierreprinetti mandre

openshift-ci-robot · 2020-12-10T22:01:14Z

@EmilienM: The label(s) platform/openstack cannot be applied, because the repository doesn't have them

Details

In response to this:

/label platform/openstack
/assign EmilienM
/cc pierreprinetti mandre

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

EmilienM · 2020-12-12T14:54:46Z

/retest

EmilienM · 2020-12-15T00:38:51Z

/retest

mandre · 2020-12-15T09:59:34Z

Also, this needs a valid BZ because we're in feature freeze and only patches fixing a bug are allowed to merge.

Before creating a machine in a given AZ, it'll check that the AZ actually exists and is available. JIRA: https://issues.redhat.com/browse/OSASINFRA-1848 Signed-off-by: Emilien Macchi <emilien@redhat.com>

mandre

Nice, this is passing CI now. All that is missing is a related BZ so that this can merge.

openshift-ci-robot · 2020-12-16T19:13:43Z

@EmilienM: This pull request references Bugzilla bug 1908466, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1908466: check if compute AZ is available

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-12-16T19:13:54Z

@EmilienM: This pull request references Bugzilla bug 1908466, which is invalid:

expected the bug to target the "4.7.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1908466: check if compute AZ is available

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

EmilienM · 2020-12-16T19:14:55Z

/bugzilla refresh

openshift-ci-robot · 2020-12-16T19:15:00Z

@EmilienM: An error was encountered adding this pull request to the external tracker bugs for bug 1908466 on the Bugzilla server at https://bugzilla.redhat.com:

JSONRPC error 32000: There was an error reported for the RPC call to Jira: There was an error reported for a GitHub REST call. URL: https://api.github.com/repos/openshift/cluster-api-provider-openstack/pulls/143 Error: 403 Forbidden at /loader/0x5595783f2e38/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. at /loader/0x5595783f2e38/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 111. eval {...} called at /loader/0x5595783f2e38/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 98 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559586...', 'https://api.github.com/repos/openshift/cluster-api-provider-o...', 'GET') called at /loader/0x5595783f2e38/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559586...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x5595860513d0)') called at /loader/0x5595783f2e38/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x5595783f2e38/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x5595860513d0)', 1) called at /loader/0x5595783f2e38/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x55958532f890)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x5595857c2410)', 'HASH(0x5595851db578)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x5595851db578)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x5595865fe630)') called at /loader/0x5595783f2e38/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559585ede358)') called at (eval 2674) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5595852b73d8)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5595852b73d8)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x55958660a4a8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x55958662a610)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x55958662a610)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55958660a4a8)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55958660a4a8)') called at (eval 2674) line 0 eval {...} called at (eval 2674) line 0 at /var/www/html/bugzilla/Bugzilla/Error.pm line 130. Bugzilla::Error::_throw_error('global/user-error.html.tmpl', 'ext_bz_rest_error', 'HASH(0x5595860077e8)') called at /var/www/html/bugzilla/Bugzilla/Error.pm line 193 Bugzilla::Error::ThrowUserError('ext_bz_rest_error', 'HASH(0x5595860077e8)') called at /loader/0x5595783f2e38/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 120 Bugzilla::Extension::ExternalBugs::Type::GitHub::_do_rest_call('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559586...', 'https://api.github.com/repos/openshift/cluster-api-provider-o...', 'GET') called at /loader/0x5595783f2e38/Bugzilla/Extension/ExternalBugs/Type/GitHub.pm line 62 Bugzilla::Extension::ExternalBugs::Type::GitHub::get_data('Bugzilla::Extension::ExternalBugs::Type::GitHub=HASH(0x559586...', 'Bugzilla::Extension::ExternalBugs::Bug=HASH(0x5595860513d0)') called at /loader/0x5595783f2e38/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 eval {...} called at /loader/0x5595783f2e38/Bugzilla/Extension/ExternalBugs/Bug.pm line 302 Bugzilla::Extension::ExternalBugs::Bug::update_ext_info('Bugzilla::Extension::ExternalBugs::Bug=HASH(0x5595860513d0)', 1) called at /loader/0x5595783f2e38/Bugzilla/Extension/ExternalBugs/Bug.pm line 125 Bugzilla::Extension::ExternalBugs::Bug::create('Bugzilla::Extension::ExternalBugs::Bug', 'HASH(0x55958532f890)') called at /var/www/html/bugzilla/extensions/ExternalBugs/Extension.pm line 940 Bugzilla::Extension::ExternalBugs::bug_start_of_update('Bugzilla::Extension::ExternalBugs=HASH(0x5595857c2410)', 'HASH(0x5595851db578)') called at /var/www/html/bugzilla/Bugzilla/Hook.pm line 21 Bugzilla::Hook::process('bug_start_of_update', 'HASH(0x5595851db578)') called at /var/www/html/bugzilla/Bugzilla/Bug.pm line 1173 Bugzilla::Bug::update('Bugzilla::Bug=HASH(0x5595865fe630)') called at /loader/0x5595783f2e38/Bugzilla/Extension/ExternalBugs/WebService.pm line 88 Bugzilla::Extension::ExternalBugs::WebService::add_external_bug('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x559585ede358)') called at (eval 2674) line 1 eval ' $procedure->{code}->($self, @params) ;' called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 220 JSON::RPC::Legacy::Server::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5595852b73d8)') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 297 Bugzilla::WebService::Server::JSONRPC::_handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...', 'HASH(0x5595852b73d8)') called at /usr/share/perl5/vendor_perl/JSON/RPC/Legacy/Server.pm line 126 JSON::RPC::Legacy::Server::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/Bugzilla/WebService/Server/JSONRPC.pm line 70 Bugzilla::WebService::Server::JSONRPC::handle('Bugzilla::WebService::Server::JSONRPC::Bugzilla::Extension::E...') called at /var/www/html/bugzilla/jsonrpc.cgi line 31 ModPerl::ROOT::Bugzilla::ModPerl::ResponseHandler::var_www_html_bugzilla_jsonrpc_2ecgi::handler('Apache2::RequestRec=SCALAR(0x55958660a4a8)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 eval {...} called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 207 ModPerl::RegistryCooker::run('Bugzilla::ModPerl::ResponseHandler=HASH(0x55958662a610)') called at /usr/lib64/perl5/vendor_perl/ModPerl/RegistryCooker.pm line 173 ModPerl::RegistryCooker::default_handler('Bugzilla::ModPerl::ResponseHandler=HASH(0x55958662a610)') called at /usr/lib64/perl5/vendor_perl/ModPerl/Registry.pm line 32 ModPerl::Registry::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55958660a4a8)') called at /var/www/html/bugzilla/mod_perl.pl line 139 Bugzilla::ModPerl::ResponseHandler::handler('Bugzilla::ModPerl::ResponseHandler', 'Apache2::RequestRec=SCALAR(0x55958660a4a8)') called at (eval 2674) line 0 eval {...} called at (eval 2674) line 0
Please contact an administrator to resolve this issue, then request a bug refresh with /bugzilla refresh.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

EmilienM · 2020-12-16T19:15:48Z

@mandre done! thanks for your review.

mandre

/lgtm
/approve

openshift-ci-robot · 2020-12-17T12:36:30Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [mandre]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pierreprinetti · 2020-12-17T13:20:09Z

/bugzilla refresh

openshift-ci-robot · 2020-12-17T13:20:17Z

@pierreprinetti: This pull request references Bugzilla bug 1908466, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.7.0) matches configured target release for branch (4.7.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti · 2020-12-17T13:20:39Z

/label platform/openstack

openshift-ci-robot · 2020-12-17T13:20:40Z

@pierreprinetti: The label(s) platform/openstack cannot be applied, because the repository doesn't have them

Details

In response to this:

/label platform/openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-12-17T14:27:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-12-17T15:22:37Z

@EmilienM: All pull requests linked via external trackers have merged:

openshift/cluster-api-provider-openstack#143

Bugzilla bug 1908466 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1908466: check if compute AZ is available

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot requested review from adduarte and pierreprinetti December 10, 2020 21:57

EmilienM mentioned this pull request Dec 10, 2020

check if compute AZ is available #142

Closed

openshift-ci-robot assigned EmilienM Dec 10, 2020

openshift-ci-robot requested a review from mandre December 10, 2020 22:01

EmilienM force-pushed the az/check branch from a8a1f0e to 71dedc1 Compare December 11, 2020 23:40

mandre requested changes Dec 15, 2020

View reviewed changes

Comment thread pkg/cloud/openstack/clients/machineservice.go

Comment thread pkg/cloud/openstack/clients/machineservice.go

Comment thread pkg/cloud/openstack/clients/machineservice.go

check if compute AZ is available

82d9dc3

Before creating a machine in a given AZ, it'll check that the AZ actually exists and is available. JIRA: https://issues.redhat.com/browse/OSASINFRA-1848 Signed-off-by: Emilien Macchi <emilien@redhat.com>

EmilienM force-pushed the az/check branch from 71dedc1 to 82d9dc3 Compare December 15, 2020 16:24

mandre reviewed Dec 16, 2020

View reviewed changes

EmilienM changed the title ~~check if compute AZ is available~~ Bug 1908466: check if compute AZ is available Dec 16, 2020

openshift-ci-robot added the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Dec 16, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Dec 16, 2020

mandre approved these changes Dec 17, 2020

View reviewed changes

openshift-ci-robot assigned mandre Dec 17, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2020

openshift-ci-robot removed the bugzilla/severity-unspecified Referenced Bugzilla bug's severity is unspecified for the PR. label Dec 17, 2020

openshift-merge-robot merged commit eef0b0f into openshift:master Dec 17, 2020

pierreprinetti deleted the az/check branch December 17, 2020 23:27

Conversation

EmilienM commented Dec 10, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

EmilienM commented Dec 10, 2020

Uh oh!

openshift-ci-robot commented Dec 10, 2020

Uh oh!

EmilienM commented Dec 12, 2020

Uh oh!

EmilienM commented Dec 15, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

mandre commented Dec 15, 2020

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Dec 16, 2020

Uh oh!

openshift-ci-robot commented Dec 16, 2020

Uh oh!

EmilienM commented Dec 16, 2020

Uh oh!

openshift-ci-robot commented Dec 16, 2020

Uh oh!

EmilienM commented Dec 16, 2020

Uh oh!

mandre left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Dec 17, 2020

Uh oh!

pierreprinetti commented Dec 17, 2020

Uh oh!

openshift-ci-robot commented Dec 17, 2020

Uh oh!

pierreprinetti commented Dec 17, 2020

Uh oh!

openshift-ci-robot commented Dec 17, 2020

Uh oh!

openshift-bot commented Dec 17, 2020

Uh oh!

openshift-ci-robot commented Dec 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

EmilienM commented Dec 10, 2020 •

edited

Loading