Skip to content

Remove pkg/errors dependency#155

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:remove_pkg_errors
Feb 15, 2021
Merged

Remove pkg/errors dependency#155
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
shiftstack:remove_pkg_errors

Conversation

@pierreprinetti
Copy link
Copy Markdown

@pierreprinetti pierreprinetti commented Jan 14, 2021

Use the new fmt.Errorf "%w" verb instead.

/hold Can wait until 4.8 master is open.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 14, 2021
@pierreprinetti
Remove pkg/errors dependency
cc7bf04 
Use the new fmt.Errorf "%w" verb instead.
mandre
mandre approved these changes Feb 9, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/bugzilla refresh

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 9, 2021

@mandre: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

/lgtm
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 9, 2021
@mandre
Copy link
Copy Markdown
Member

mandre commented Feb 9, 2021

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 9, 2021
mandre
mandre reviewed Feb 15, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Feb 15, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2021
@openshift-merge-robot openshift-merge-robot merged commit c480729 into openshift:master Feb 15, 2021
@pierreprinetti pierreprinetti deleted the remove_pkg_errors branch February 15, 2021 14:30
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@jichenjc @pierreprinetti
move rbac from hard code to generate (openshift#189)
56fed5d 
* move rbac from hard code to generate

use control-gen tool to
generate rbac/rbac_role*.yaml files instead of hard code them

Fixes openshift#155

* make crd file generated automatically

use
go run vendor/sigs.k8s.io/controller-tools/cmd/controller-gen/main.go crd
to create instead of using hard code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre approved these changes

@Fedosin Fedosin Awaiting requested review from Fedosin

@mdbooth mdbooth Awaiting requested review from mdbooth

Assignees

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pierreprinetti @openshift-ci-robot @mandre @openshift-merge-robot