Bump gophercloud#193
Merged
openshift-merge-robot merged 3 commits intoopenshift:masterfrom Jul 23, 2021
Merged
Conversation
Remove an internally-defined function that is present in the latest release of gophercloud/utils.
pierreprinetti
force-pushed
the
bump_gophercloud
branch
from
81a5c54 to
a9c9c13
Compare
servergroups.List has changed its signature.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
the openstackproviderspec removed in openshift#193 and because of missing 'metav1.ObjectMeta' so it failed to generate the CRD file. Fixes openshift#217
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In separate commits, replace a function definition with the corresponding one that was made available in the latest release of gophercloud/utils, and adapt the code to the other changes in Gophercloud.