-
Notifications
You must be signed in to change notification settings - Fork 33
Bug 2037484: Bump k8s to 1.23 #211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like there's some breaking change to be taken care of |
This is the result of: ``` go get github.com/openshift/api@7c47a5f go get github.com/openshift/client-go@7385dd6 go get github.com/openshift/machine-api-operator@7ba373c go mod vendor go mod tidy ```
Copy machineset CRD from [1] to fix validation issue in unit tests. [1] https://github.com/openshift/machine-api-operator/blob/d122c63/install/0000_30_machine-api-operator_03_machineset.crd.yaml
|
@mandre: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
The proxy environment is out of order, correct? @EmilienM /approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: pierreprinetti The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@mandre: This pull request references Bugzilla bug 2037484, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@openshift-ci[bot]: GitHub didn't allow me to request PR reviews from the following users: eurijon. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
@mandre: All pull requests linked via external trackers have merged: Bugzilla bug 2037484 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is the result of: