Add support to IPv6 in Machine's status#259
Add support to IPv6 in Machine's status#259openshift-merge-robot merged 1 commit intoopenshift:release-0.7from
Conversation
Dual-stack clusters require that the Machine's status contains the IPv6 address. This commit removed the check that would skip the addition of IPv6 to the Machines. Also, it ensures the IPv4 addresses of each Network remains being the first ones listed in the Machines given there are operations that rely on the first address of each network.
|
/cc @mandre |
|
where are the CI jobs for that branch? |
|
/lgtm I know this has been manually tested so feel free to unhold once we're sure it can land. |
openshift-ci
Bot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: EmilienM The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
mandre
left a comment
mandre
left a comment
There was a problem hiding this comment.
/lgtm
Clean cherry-pick of kubernetes-sigs@5926f47
The code that comes into CAPO is not used directly, we first need to perform a CAPO bump in MAPO. It would be good to figure out if there's a way to evaluate the code that merges into CAPO. Otherwise, we'll have to wait until the bump in MAPO to discover potential issues. |
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
the permission by default maybe -rw--r--r and this file actually contains the clouds password...
4 participants
Dual-stack clusters require that the Machine's status contains the IPv6 address. This commit removed the check that would skip the addition of IPv6 to the Machines. Also, it ensures the IPv4 addresses of each Network remains being the first ones listed in the Machines given there are operations that rely on the first address of each network.
Cherry-pick of kubernetes-sigs@5926f47