Skip to content

OCPBUGS-20780: deps: Upgrade golang.org/x/net to v0.17.0#277

Merged
openshift-ci[bot] merged 1 commit intoopenshift:release-4.12from
shiftstack:net_4.12
Oct 25, 2023
Merged

OCPBUGS-20780: deps: Upgrade golang.org/x/net to v0.17.0#277
openshift-ci[bot] merged 1 commit intoopenshift:release-4.12from
shiftstack:net_4.12

Conversation

@pierreprinetti
Copy link
Copy Markdown

@pierreprinetti pierreprinetti commented Oct 25, 2023

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 25, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 25, 2023

@pierreprinetti: This pull request references Jira Issue OCPBUGS-20780, which is invalid:

  • expected Jira Issue OCPBUGS-20780 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Copy Markdown
Author

pierreprinetti commented Oct 25, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 25, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 25, 2023

@pierreprinetti: This pull request references Jira Issue OCPBUGS-20780, which is valid. The bug has been moved to the POST state.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.12.z) matches configured target version for branch (4.12.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • dependent bug Jira Issue OCPBUGS-20799 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-20799 targets the "4.13.z" version, which is one of the valid target versions: 4.13.0, 4.13.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (itbrown@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Copy Markdown
Author

pierreprinetti commented Oct 25, 2023

/retest-required

mandre
mandre reviewed Oct 25, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even though we're not using this branch directly in OCP, let's patch them.
/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 25, 2023
@mandre
Copy link
Copy Markdown
Member

mandre commented Oct 25, 2023

/label backport-risk-assessed
And manually adding the approved label since we don't have a DOWNSTREAM_OWNERS file in that branch.

@mandre mandre added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 25, 2023
@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 25, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 25, 2023

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 25, 2023

@pierreprinetti: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eurijon
Copy link
Copy Markdown

eurijon commented Oct 25, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Oct 25, 2023
@openshift-ci openshift-ci Bot merged commit f13e381 into openshift:release-4.12 Oct 25, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Oct 25, 2023

@pierreprinetti: Jira Issue OCPBUGS-20780: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-20780 has been moved to the MODIFIED state.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-robot
Copy link
Copy Markdown

openshift-merge-robot commented Oct 26, 2023

Fix included in accepted release 4.12.0-0.nightly-2023-10-26-005853

@pierreprinetti pierreprinetti deleted the net_4.12 branch October 26, 2023 10:28
@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Nov 22, 2023

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-openstack-machine-controllers-container-v4.12.0-202311220908.p0.gf13e381.assembly.stream for distgit ose-openstack-machine-controllers.
All builds following this will include this PR.

pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@pierreprinetti
Added "new" node taints to tolerations (openshift#277)
b544085 
* Added "new" node taints to tolerations

added `node.kubernetes.io/not-ready` and
`node.kubernetes.io/unreachable`

See kubernetes/kubernetes#73001

* Removed deprecated taints
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre left review comments

Assignees

@mandre mandre

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pierreprinetti @openshift-ci-robot @mandre @eurijon @openshift-merge-robot @openshift-bot