Skip to content

NO-ISSUE: CARRY: Add DOWNSTREAM_OWNERS#291

Closed
pierreprinetti wants to merge 1 commit intoopenshift:release-4.14from
shiftstack:downstream_owners
Closed

NO-ISSUE: CARRY: Add DOWNSTREAM_OWNERS#291
pierreprinetti wants to merge 1 commit intoopenshift:release-4.14from
shiftstack:downstream_owners

Conversation

@pierreprinetti
Copy link
Copy Markdown

No description provided.

@pierreprinetti pierreprinetti changed the title CARRY: Add DOWNSTREAM_OWNERS NO-ISSUE: CARRY: Add DOWNSTREAM_OWNERS Dec 22, 2023
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 22, 2023
@openshift-ci-robot
Copy link
Copy Markdown

@pierreprinetti: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM
Copy link
Copy Markdown
Member

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2023
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Dec 22, 2023

@pierreprinetti: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-proxy 4d31c18 link false /test e2e-openstack-proxy

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@eurijon
Copy link
Copy Markdown

eurijon commented Dec 22, 2023

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 22, 2023
@mdbooth
Copy link
Copy Markdown

mdbooth commented Jan 2, 2024

/approve

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 2, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: EmilienM, mdbooth

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mdbooth
Copy link
Copy Markdown

mdbooth commented Jan 2, 2024

@mandre You might have to force this in. Any idea how we ended up in this state?

Copy link
Copy Markdown
Member

@mandre mandre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clean cherry-pick of #269.

But because of openshift/release#44167, we can no longer merge in release-4.14. This shouldn't be an issue in theory (rational here) since we have no plans to backport changes to the release-4.14 branch.

Before I approve, and manually forces this in, can you let me know why you think this patch is needed?

@pierreprinetti
Copy link
Copy Markdown
Author

pierreprinetti commented Jan 3, 2024

Closing under the assumption that this branch is not and never was used in OpenShift.
/close

@openshift-ci openshift-ci Bot closed this Jan 3, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jan 3, 2024

@pierreprinetti: Closed this PR.

Details

In response to this:

This branch is not and never was used in OpenShift.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti pierreprinetti deleted the downstream_owners branch January 3, 2024 14:38
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants