Skip to content

Merge https://github.com/kubernetes-sigs/cluster-api-provider-openstack:release-0.10 into main#310

Closed
shiftstack-merge-bot[bot] wants to merge 15 commits intoopenshift:mainfrom
shiftstack:merge-bot-main
Closed

Merge https://github.com/kubernetes-sigs/cluster-api-provider-openstack:release-0.10 into main#310
shiftstack-merge-bot[bot] wants to merge 15 commits intoopenshift:mainfrom
shiftstack:merge-bot-main

Conversation

@shiftstack-merge-bot
Copy link
Copy Markdown

@shiftstack-merge-bot shiftstack-merge-bot Bot commented May 2, 2024

No description provided.

mdbooth and others added 2 commits April 30, 2024 15:48
@mdbooth
Fix webhook panic when adding managed security groups
34f9c73 
Also adds fuzz tests which would have caught this and any similar
issues.
@k8s-ci-robot
Merge pull request kubernetes-sigs#2044 from k8s-infra-cherrypick-rob…
6b2ab8a 
…ot/cherry-pick-2043-to-release-0.10

[release-0.10] 🐛 Fix webhook panic when adding managed security groups
@openshift-ci openshift-ci Bot requested review from EmilienM and mandre May 2, 2024 12:19
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 2, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 2, 2024

Hi @shiftstack-merge-bot[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

mdbooth and others added 10 commits May 6, 2024 14:19
@mdbooth
Fix panic executing manager without valid kube context
5d57858
@pierreprinetti
Refactoring: never assign unacceptable TLS versions
7731959 
This commit makes security linting easier by never setting a TLS version
outside v1.2 or v1.3, even in case of an unacceptable user input.
@k8s-ci-robot
Merge pull request kubernetes-sigs#2061 from k8s-infra-cherrypick-rob…
f049a35 
…ot/cherry-pick-2057-to-release-0.10

[release-0.10] 🐛 Fix panic executing manager without valid kube context
@k8s-ci-robot
Merge pull request kubernetes-sigs#2062 from k8s-infra-cherrypick-rob…
1960fbb 
…ot/cherry-pick-2037-to-release-0.10

[release-0.10] 🌱 Refactoring: never assign unacceptable TLS versions
@k8s-ci-robot
Merge pull request kubernetes-sigs#2059 from k8s-infra-cherrypick-rob…
c0d24e4 
…ot/cherry-pick-2056-to-release-0.10

[release-0.10] 🐛 Fix empty version output in release builds
@kashifest
Fix nil pointer issue while creating port
a8285b1 
Signed-off-by: Kashif Khan <kashif.khan@est.tech>
@k8s-ci-robot
Merge pull request kubernetes-sigs#2065 from k8s-infra-cherrypick-rob…
57c6caf 
…ot/cherry-pick-2064-to-release-0.10

[release-0.10] Fix nil pointer issue while creating port
@mdbooth
Set FallbackToLogsOnError on CAPO manager
0ac498d
@k8s-ci-robot
Merge pull request kubernetes-sigs#2072 from k8s-infra-cherrypick-rob…
ab64794 
…ot/cherry-pick-2070-to-release-0.10

[release-0.10] 🌱 Set FallbackToLogsOnError on CAPO manager
Merge https://github.com/kubernetes-sigs/cluster-api-provider-opensta…
b937e90 
…ck:release-0.10 into main
@EmilienM
Copy link
Copy Markdown
Member

EmilienM commented May 9, 2024

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 9, 2024
@EmilienM
Copy link
Copy Markdown
Member

EmilienM commented May 9, 2024

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 9, 2024
@EmilienM
Copy link
Copy Markdown
Member

EmilienM commented May 9, 2024

/approve
/lgtm

CI jobs are required anyway.

@mdbooth
Copy link
Copy Markdown

mdbooth commented May 9, 2024

/lgtm too

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 9, 2024
@mdbooth
Copy link
Copy Markdown

mdbooth commented May 9, 2024

Why can't @EmilienM
/approve
?

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 9, 2024

/retest-required

Remaining retests: 0 against base HEAD 429fbf5 and 2 for PR HEAD b937e90 in total

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 9, 2024

@shiftstack-merge-bot[bot]: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/test-openshift b937e90 link true /test test-openshift

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@mdbooth
Copy link
Copy Markdown

mdbooth commented May 9, 2024

Closed in favour of manual merge: #312

/close

@openshift-ci openshift-ci Bot closed this May 9, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 9, 2024

@mdbooth: Closed this PR.

Details

In response to this:

Closed in favour of manual merge: #312

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@EmilienM EmilienM deleted the merge-bot-main branch May 9, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EmilienM EmilienM Awaiting requested review from EmilienM

@mandre mandre Awaiting requested review from mandre

Assignees

@EmilienM EmilienM

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@EmilienM @mdbooth @openshift-ci-robot @k8s-ci-robot @pierreprinetti @kashifest