Skip to content

CARRY: Remove webhooks#373

Closed
stephenfin wants to merge 1 commit intoopenshift:release-0.9from
shiftstack:remove-webhooks
Closed

CARRY: Remove webhooks#373
stephenfin wants to merge 1 commit intoopenshift:release-0.9from
shiftstack:remove-webhooks

Conversation

@stephenfin
Copy link
Copy Markdown

@stephenfin stephenfin commented Jul 14, 2025

We do not use these currently in OpenShift, and the way they were designed in release 0.9 causes dependency issues.

/hold
/cc @mandre

@stephenfin
CARRY: Remove webhooks
cfe31b2 
We do not use these currently in OpenShift, and the way they were
designed in release 0.9 causes dependency issues.

Signed-off-by: Stephen Finucane <stephenfin@redhat.com>
@openshift-ci openshift-ci Bot requested a review from mandre July 14, 2025 12:23
@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 14, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jul 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Copy Markdown

openshift-bot commented Oct 13, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci Bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 13, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 13, 2025
@openshift-merge-robot
Copy link
Copy Markdown

openshift-merge-robot commented Oct 13, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stephenfin
Copy link
Copy Markdown
Author

stephenfin commented Oct 13, 2025

/close

We did this via #374 instead.

@openshift-ci openshift-ci Bot closed this Oct 13, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Oct 13, 2025

@stephenfin: Closed this PR.

Details

In response to this:

/close

We did this via #374 instead.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stephenfin stephenfin deleted the remove-webhooks branch October 13, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre Awaiting requested review from mandre

Assignees

No one assigned

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stephenfin @openshift-bot @openshift-merge-robot