NO-JIRA: Update manifests generator#411
NO-JIRA: Update manifests generator#411openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
Conversation
Update manifests-gen to openshift/cluster-capi-operator#524 which adds the openshift.io/required-scc: restricted-v2 annotation to provider Deployments and moves the workload management annotation to kustomize. Signed-off-by: Damiano Donati <damiano.donati@gmail.com>
WalkthroughThis pull request adds a pod annotation to the Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 11 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (11 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@openshift/tools/go.mod`:
- Line 3: The openshift/tools module declares `go 1.25.0` which conflicts with
CI pinned Go 1.24.12; update the `go` directive in openshift/tools/go.mod from
`1.25.0` to `1.24.0` so the `ocp-manifests` target (which runs `cd tools && go
run ...`) can build in CI, or alternatively update the CI/Dockerfile
`GO_VERSION` to `1.25.0`+ to match the module; locate and change the `go` line
in the openshift/tools/go.mod file (or adjust the CI/Dockerfile `GO_VERSION`
variable) accordingly.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c8878c12-34e3-423a-b5d1-a8c0bab1c31a
⛔ Files ignored due to path filters (298)
openshift/tools/go.sumis excluded by!**/*.sumopenshift/tools/vendor/github.com/containerd/stargz-snapshotter/estargz/build.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/containerd/stargz-snapshotter/estargz/errorutil/errors.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/containerd/stargz-snapshotter/estargz/estargz.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/containerd/stargz-snapshotter/estargz/gzip.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/containerd/stargz-snapshotter/estargz/testutil.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/containerd/stargz-snapshotter/estargz/types.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/AUTHORSis excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/NOTICEis excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/cli/config/config.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/cli/config/configfile/file.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/cli/config/configfile/file_unix.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/cli/config/configfile/file_windows.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/cli/config/credentials/credentials.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/cli/config/credentials/default_store.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/cli/config/credentials/default_store_darwin.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/cli/config/credentials/default_store_linux.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/cli/config/credentials/default_store_unsupported.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/cli/config/credentials/default_store_windows.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/cli/config/credentials/file_store.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/cli/config/credentials/native_store.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/cli/config/memorystore/store.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/cli/cli/config/types/authconfig.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/distribution/registry/client/auth/challenge/addr.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/distribution/registry/client/auth/challenge/authchallenge.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/docker-credential-helpers/LICENSEis excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/docker-credential-helpers/client/client.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/docker-credential-helpers/client/command.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/docker-credential-helpers/credentials/credentials.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/docker-credential-helpers/credentials/error.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/docker-credential-helpers/credentials/helper.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/docker/docker-credential-helpers/credentials/version.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/emicklei/go-restful/v3/.travis.ymlis excluded by!**/vendor/**openshift/tools/vendor/github.com/emicklei/go-restful/v3/CHANGES.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/emicklei/go-restful/v3/README.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/emicklei/go-restful/v3/curly.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/emicklei/go-restful/v3/custom_verb.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/emicklei/go-restful/v3/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/fxamacker/cbor/v2/.golangci.ymlis excluded by!**/vendor/**openshift/tools/vendor/github.com/fxamacker/cbor/v2/README.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/fxamacker/cbor/v2/cache.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/fxamacker/cbor/v2/decode.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/fxamacker/cbor/v2/decode_map_utils.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/fxamacker/cbor/v2/diagnose.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/fxamacker/cbor/v2/encode.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/fxamacker/cbor/v2/simplevalue.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/fxamacker/cbor/v2/stream.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/fxamacker/cbor/v2/structfields.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/fxamacker/cbor/v2/valid.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonpointer/.cliff.tomlis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonpointer/.gitignoreis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonpointer/.golangci.ymlis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonpointer/CODE_OF_CONDUCT.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonpointer/CONTRIBUTORS.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonpointer/LICENSEis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonpointer/NOTICEis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonpointer/README.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonpointer/SECURITY.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonpointer/errors.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonpointer/pointer.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonreference/.editorconfigis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonreference/.gitignoreis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonreference/.golangci.ymlis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonreference/CODE_OF_CONDUCT.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonreference/CONTRIBUTORS.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonreference/NOTICEis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonreference/README.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonreference/SECURITY.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonreference/internal/normalize_url.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/jsonreference/reference.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/.codecov.ymlis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/.gitignoreis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/.golangci.ymlis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/.mockery.ymlis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/CODE_OF_CONDUCT.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/CONTRIBUTORS.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/README.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/SECURITY.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/cmdutils/LICENSEis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/cmdutils/cmd_utils.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/cmdutils/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/cmdutils_iface.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/conv/LICENSEis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/conv/convert.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/conv/convert_types.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/conv/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/conv/format.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/conv/sizeof.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/conv/type_constraints.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/conv_iface.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/convert.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/convert_types.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/errors.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/file.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/fileutils/LICENSEis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/fileutils/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/fileutils/file.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/fileutils/path.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/fileutils_iface.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/go.workis excluded by!**/*.work,!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/go.work.sumis excluded by!**/*.sum,!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/initialism_index.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/json.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonname/LICENSEis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonname/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonname/name_provider.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonname_iface.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/LICENSEis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/README.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/adapters/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/adapters/ifaces/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/adapters/ifaces/ifaces.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/adapters/ifaces/registry_iface.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/adapters/registry.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/adapters/stdlib/json/adapter.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/adapters/stdlib/json/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/adapters/stdlib/json/lexer.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/adapters/stdlib/json/ordered_map.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/adapters/stdlib/json/pool.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/adapters/stdlib/json/register.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/adapters/stdlib/json/writer.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/concat.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/json.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils/ordered_map.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/jsonutils_iface.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/loading/LICENSEis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/loading/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/loading/errors.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/loading/json.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/loading/loading.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/loading/options.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/loading/yaml.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/loading_iface.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/mangling/BENCHMARK.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/mangling/LICENSEis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/mangling/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/mangling/initialism_index.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/mangling/name_lexem.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/mangling/name_mangler.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/mangling/options.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/mangling/pools.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/mangling/split.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/mangling/string_bytes.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/mangling/util.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/mangling_iface.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/name_lexem.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/net.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/netutils/LICENSEis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/netutils/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/netutils/net.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/netutils_iface.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/split.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/stringutils/LICENSEis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/stringutils/collection_formats.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/stringutils/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/stringutils/strings.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/stringutils_iface.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/typeutils/LICENSEis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/typeutils/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/typeutils/types.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/typeutils_iface.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/util.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/yaml.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/yamlutils/LICENSEis excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/yamlutils/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/yamlutils/errors.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/yamlutils/ordered_map.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/yamlutils/yaml.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/go-openapi/swag/yamlutils_iface.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/AUTHORSis excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/CONTRIBUTORSis excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/LICENSEis excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/Makefileis excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/clone.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/custom_gogo.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/decode.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/deprecated.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/discard.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/duration.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/duration_gogo.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/encode.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/encode_gogo.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/equal.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/extensions.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/extensions_gogo.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/lib.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/lib_gogo.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/message_set.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/pointer_reflect.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/pointer_reflect_gogo.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/pointer_unsafe.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/pointer_unsafe_gogo.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/properties.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/properties_gogo.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/skip_gogo.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/table_marshal.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/table_marshal_gogo.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/table_merge.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/table_unmarshal.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/table_unmarshal_gogo.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/text.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/text_gogo.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/text_parser.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/timestamp.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/timestamp_gogo.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/wrappers.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/proto/wrappers_gogo.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/gogo/protobuf/sortkeys/sortkeys.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/gnostic-models/extensions/extension.protois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/gnostic-models/openapiv2/OpenAPIv2.protois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/gnostic-models/openapiv3/OpenAPIv3.protois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/gnostic-models/openapiv3/annotations.protois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/internal/and/and_closer.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/internal/compression/compression.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/internal/estargz/estargz.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/internal/gzip/zip.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/internal/redact/redact.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/internal/retry/retry.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/internal/retry/wait/kubernetes_apimachinery_wait.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/internal/verify/verify.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/internal/zstd/zstd.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/authn/README.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/authn/anon.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/authn/auth.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/authn/authn.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/authn/basic.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/authn/bearer.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/authn/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/authn/keychain.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/authn/multikeychain.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/compression/compression.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/logs/logs.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/config.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/empty/README.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/empty/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/empty/image.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/empty/index.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/hash.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/image.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/index.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/layer.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/manifest.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/match/match.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/mutate/README.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/mutate/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/mutate/image.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/mutate/index.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/mutate/mutate.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/mutate/rebase.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/partial/README.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/partial/compressed.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/partial/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/partial/image.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/partial/index.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/partial/uncompressed.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/partial/with.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/platform.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/progress.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/README.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/catalog.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/check.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/delete.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/descriptor.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/fetcher.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/image.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/index.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/layer.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/list.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/mount.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/multi_write.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/options.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/progress.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/puller.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/pusher.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/referrers.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/schema1.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/README.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/basic.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/bearer.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/error.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/logger.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/ping.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/retry.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/schemer.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/scope.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/transport.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/transport/useragent.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/remote/write.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/stream/README.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/stream/layer.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/tarball/README.mdis excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/tarball/doc.gois excluded by!**/vendor/**openshift/tools/vendor/github.com/google/go-containerregistry/pkg/v1/tarball/image.gois excluded by!**/vendor/**
📒 Files selected for processing (2)
openshift/capi-operator-manifests/default/manifests.yamlopenshift/tools/go.mod
|
/retest |
|
@damdo: This pull request explicitly references no jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/retest |
|
/lgtm |
|
@racheljpg: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
@theobarberbany: changing LGTM is restricted to collaborators DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/verified by ci |
|
@damdo: Jira verification commands are restricted to collaborators for this repo. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
mandre
left a comment
There was a problem hiding this comment.
This is a simple go.mod update to use a newer version of github.com/openshift/cluster-capi-operator/manifests-gen
The hypershift job is currently broken (waiting on https://redhat.atlassian.net/browse/OCPSTRAT-2478) so we'll likely have to override it.
/lgtm
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mandre, theobarberbany The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Thanks @mandre Should we override the hypershift job then? |
|
/verified by ci passing |
|
@damdo: Jira verification commands are restricted to collaborators for this repo. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
What does |
|
|
/override ci/prow/e2e-hypershift |
|
@stephenfin: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@stephenfin: Overrode contexts on behalf of stephenfin: ci/prow/e2e-hypershift DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@damdo: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
manifests-gento openshift/cluster-capi-operator#524 which:openshift.io/required-scc: restricted-v2annotation to provider Deployment pod templatestarget.workload.openshift.io/management) from Go code to a kustomize patchTest plan
openshift.io/required-scc: restricted-v2annotationSummary by CodeRabbit