bug 1746019: Add event recording for machines#63
bug 1746019: Add event recording for machines#63openshift-merge-robot merged 1 commit intoopenshift:masterfrom
Conversation
openshift-ci-robot
added
approved
| - get | ||
| - list | ||
| - watch | ||
| - apiGroups: |
There was a problem hiding this comment.
do we really use this file during the deployment?
There was a problem hiding this comment.
I mean that last time I checked there was no cluster role "openstack-provider-manager-role", I need to take a look again
There was a problem hiding this comment.
all I know is that it failed until I added this ¯\(ツ)/¯
There was a problem hiding this comment.
|
/retitle bug 1746019: Add event recording for machines |
openshift-ci-robot
changed the title
|
@iamemilio: This pull request references Bugzilla bug 1746019, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/invalid-bug
|
/bugzilla refresh |
openshift-ci-robot
added
bugzilla/valid-bug
|
@ingvagabund: This pull request references Bugzilla bug 1746019, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Fedosin, iamemilio The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Just checked - all workers have events now. Thanks @iamemilio ! |
|
@iamemilio: All pull requests linked via external trackers have merged. Bugzilla bug 1746019 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Instead of hard-coding bash at the top of the startupScript, we should use the startUpScript as the base template. This will allow us to accept other formats, other than bash, as startUpScripts.
Instead of hard-coding bash at the top of the startupScript, we should use the startUpScript as the base template. This will allow us to accept other formats, other than bash, as startUpScripts.
5 participants
What this PR does / why we need it: Enables Event recording so that the interface is comparable to CAPA does things
Which issue(s) this PR fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1746019