[WIP] Boot from volume: incorporate options#68
Closed
pierreprinetti wants to merge 1 commit intoopenshift:masterfrom
pierreprinetti:from_volume
Closed
[WIP] Boot from volume: incorporate options#68pierreprinetti wants to merge 1 commit intoopenshift:masterfrom pierreprinetti:from_volume
pierreprinetti wants to merge 1 commit intoopenshift:masterfrom
pierreprinetti:from_volume
Conversation
With this change, the options for booting a machine from a volume are no longer discarded.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: pierreprinetti The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
size/XS
Author
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
pierreprinetti
changed the title
openshift-ci-robot
added
the
do-not-merge/work-in-progress
Author
|
Closing, as the code was not complete in the first place and requires more logic to actually work as intended. |
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Mar 27, 2020
…ft#68) * A filter can be passed in machines.yaml that allows networks to be searched for in openstack * Dependancies Updated and Gophercloud Networking dependancies added
racheljpg
pushed a commit
to racheljpg/cluster-api-provider-openstack
that referenced
this pull request
Dec 20, 2023
…ft#68) * A filter can be passed in machines.yaml that allows networks to be searched for in openstack * Dependancies Updated and Gophercloud Networking dependancies added
pierreprinetti
pushed a commit
to shiftstack/cluster-api-provider-openstack
that referenced
this pull request
Apr 22, 2024
…ft#68) * A filter can be passed in machines.yaml that allows networks to be searched for in openstack * Dependancies Updated and Gophercloud Networking dependancies added
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change, the options for booting a machine from a volume are no
longer discarded.