Skip to content

Bug 1754070: Add boot from volume support#69

Merged
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Fedosin:boot_from_volume
Sep 25, 2019
Merged

Bug 1754070: Add boot from volume support#69
openshift-merge-robot merged 2 commits intoopenshift:masterfrom
Fedosin:boot_from_volume

Conversation

@Fedosin
Copy link
Copy Markdown

@Fedosin Fedosin commented Sep 24, 2019

No description provided.

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2019
mandre
mandre reviewed Sep 24, 2019
View reviewed changes
Comment thread pkg/cloud/openstack/clients/machineservice.go Outdated
// VolumeSize: config.RootVolume.Size,
VolumeSize: 25,
// DeviceType: config.RootVolume.DeviceType,
DeviceType: "performance",
Copy link
Copy Markdown
Member

@mandre mandre Sep 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeviceType is not right, it should be VolumeType instead.

https://github.com/gophercloud/gophercloud/blob/master/openstack/compute/v2/extensions/bootfromvolume/requests.go#L81

Copy link
Copy Markdown
Member

@mandre mandre Sep 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

VolumeType was added in Stein, so we can't rely on it if we want to support OSP13 😢

https://docs.openstack.org/nova/latest/reference/api-microversion-history.html#id60

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 24, 2019
@Fedosin
Copy link
Copy Markdown
Author

Fedosin commented Sep 24, 2019

No idea why dep removed vendor/github.com/openshift/kubernetes-drain

mfedosin@winter ~/go/src/sigs.k8s.io/cluster-api-provider-openstack $ git s
mfedosin@winter ~/go/src/sigs.k8s.io/cluster-api-provider-openstack $ dep ensure -update github.com/gophercloud/gophercloud
mfedosin@winter ~/go/src/sigs.k8s.io/cluster-api-provider-openstack $ git s
M Gopkg.lock
M vendor/github.com/gophercloud/gophercloud/openstack/compute/v2/extensions/bootfromvolume/requests.go
M vendor/github.com/gophercloud/gophercloud/openstack/identity/v3/tokens/requests.go
M vendor/github.com/gophercloud/gophercloud/openstack/identity/v3/tokens/results.go
M vendor/github.com/gophercloud/gophercloud/openstack/networking/v2/extensions/security/groups/results.go
M vendor/github.com/gophercloud/gophercloud/openstack/networking/v2/networks/results.go
D vendor/github.com/openshift/kubernetes-drain/LICENSE
D vendor/github.com/openshift/kubernetes-drain/drain.go

pierreprinetti
pierreprinetti reviewed Sep 24, 2019
View reviewed changes
Comment thread pkg/cloud/openstack/clients/machineservice.go Outdated
}
blocks = append(blocks, block)

createOpts = bootfromvolume.CreateOptsExt{
Copy link
Copy Markdown

@pierreprinetti pierreprinetti Sep 24, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please take this opportunity to move here the declaration of createOpts? I find it confusing to have it so far away (line 426).

Copy link
Copy Markdown
Author

@Fedosin Fedosin Sep 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

pierreprinetti
pierreprinetti reviewed Sep 24, 2019
View reviewed changes
Comment thread pkg/cloud/openstack/clients/machineservice.go Outdated
@Fedosin Fedosin force-pushed the boot_from_volume branch 5 times, most recently from e10ad65 to 87e0440 Compare September 25, 2019 13:06
mandre
mandre reviewed Sep 25, 2019
View reviewed changes
Comment thread pkg/cloud/openstack/clients/machineservice.go Outdated

imageID, err := getImageID(is, config.RootVolume.SourceUUID)
if err != nil {
return nil, fmt.Errorf("Create new server err: %v", err)
Copy link
Copy Markdown
Member

@mandre mandre Sep 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error message could be a bit more specific.

Comment thread pkg/cloud/openstack/clients/machineservice.go
@iamemilio iamemilio changed the title Add boot from volume support Bug 1754115: Add boot from volume support Sep 25, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 25, 2019

@Fedosin: This pull request references Bugzilla bug 1754115, which is invalid:

  • expected the bug to target the "4.3.0" release, but it targets "4.2.0" instead
  • expected dependent Bugzilla bug 1754070 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1754115: Add boot from volume support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 25, 2019
@iamemilio iamemilio changed the title Bug 1754115: Add boot from volume support Bug 1754070: Add boot from volume support Sep 25, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Sep 25, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 25, 2019

@Fedosin: This pull request references Bugzilla bug 1754070, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1754070: Add boot from volume support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Sep 25, 2019
@iamemilio iamemilio mentioned this pull request Sep 25, 2019
Merged
@iamemilio
Copy link
Copy Markdown

iamemilio commented Sep 25, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 25, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 25, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Fedosin, iamemilio

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 945cf04 into openshift:master Sep 25, 2019
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Sep 25, 2019

@Fedosin: All pull requests linked via external trackers have merged. Bugzilla bug 1754070 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1754070: Add boot from volume support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Mar 27, 2020
@flaper87 @k8s-ci-robot
Let clientconfig create the AuthOptions instance (openshift#70)
d72adf0 
We were creating our own copy of AuthOptions rather than relying on the
utilities provided by clientconfig. Our copy didn't have all the info
required by gophercloud to authenticate.

Closes openshift#69
racheljpg pushed a commit to racheljpg/cluster-api-provider-openstack that referenced this pull request Dec 20, 2023
@flaper87
Let clientconfig create the AuthOptions instance (openshift#70)
39d1b06 
We were creating our own copy of AuthOptions rather than relying on the
utilities provided by clientconfig. Our copy didn't have all the info
required by gophercloud to authenticate.

Closes openshift#69
pierreprinetti pushed a commit to shiftstack/cluster-api-provider-openstack that referenced this pull request Apr 22, 2024
@flaper87 @pierreprinetti
Let clientconfig create the AuthOptions instance (openshift#70)
bb1f942 
We were creating our own copy of AuthOptions rather than relying on the
utilities provided by clientconfig. Our copy didn't have all the info
required by gophercloud to authenticate.

Closes openshift#69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mandre mandre mandre left review comments

@iamemilio iamemilio Awaiting requested review from iamemilio

+1 more reviewer

@pierreprinetti pierreprinetti pierreprinetti left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@iamemilio iamemilio

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Fedosin @openshift-ci-robot @iamemilio @mandre @pierreprinetti @openshift-merge-robot